Adds wide-gamut support #3882

fserb · 2018-08-03T20:38:07Z

This is pulling a part of: https://github.com/WICG/canvas-color-space/blob/master/CanvasColorSpaceProposal.md into the spec.

This includes Context 2D creation params and adding a new convertToBlob function to canvas and offscreenCanvas.

@domenic @whatwg/canvas

💥 Error: Wattsi server error 💥

PR Preview failed to build. (Last tried on Jan 15, 2021, 7:58 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.

🔗 Related URL

Command failed: /home/noderunner/wattsi/bin/wattsi /tmp/upload_0c739482382be255156fa8e57febe1a0 (sha not provided) rupbfr97o1k default /tmp/upload_23a1dd449af8b88e382686a6d3de6c7a

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

fserb · 2018-08-03T20:39:57Z

Implementation bugs:

Edge: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/18521261/
Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1480894
Safari: https://bugs.webkit.org/show_bug.cgi?id=188320

smfr · 2018-08-04T17:25:33Z

^gamut

fserb · 2018-08-04T17:48:07Z

ops. :) thanks.

annevk

Great to see this happening! This will also fix an open issue (haven't looked for it yet).

I think this would be easier to review if you could split the pixelFormat and convertToBlob changes into separate PRs. Would that be too much of a hassle?

Is there a plan for tests?

annevk · 2018-08-08T15:38:11Z

source

@@ -60069,6 +60082,15 @@ interface <dfn>Path2D</dfn> {

   </dd>

+   <dt><var>context</var> = <var>canvas</var> . <code data-x="dom-canvas-getContext">getContext</code>('2d' [, { [ <code data-x="dom-CanvasRenderingContext2DSettings-pixelFormat">pixelFormat</code>: "float16" ] } ] )</dt>


This is a little weird if we don't also document the default.

Ugh, this really is stressing the limits our domintro pseudo-language.

I would suggest rolling this into the previous dt/dd, as they are not mutually exclusive. My suggestion is either one of

context = canvas . getContext('2d' [, { [ alpha: false ] [, pixelFormat: "float16" ] } ] )

or give up on documenting all optionality/non-defaults and do

context = canvas . getContext('2d' [, { alpha, pixelFormat } ] )

annevk · 2018-08-08T15:43:06Z

Pinging @whatwg/canvas separately from OP as it doesn't work there due to bot reasons...

fserb · 2018-08-15T18:59:27Z

Left pixelFormat here and moving convertToBlob to a different change.
PTAL.

annevk · 2018-08-16T06:39:42Z

Comments:

If we document float16, we should also document 8-8-8-8 (maybe int8 would be more aligned?).
It seems to me we should also describe how this impacts getImageData(). In this PR it doesn't seem to be defined at all what this new color space actually means for an implementation.

domenic

This doesn't seem integrated into https://html.spec.whatwg.org/#offscreen-2d-context-creation-algorithm or https://html.spec.whatwg.org/#imagebitmaprenderingcontext-creation-algorithm . Is that intentional, or should those support pixelFormat too?

domenic · 2018-08-23T18:10:24Z

source

@@ -59318,6 +59318,17 @@ dictionary <dfn>AssignedNodesOptions</dfn> {
   <dd w-nodev>
    <pre><code class="idl" data-x="">typedef (<span>CanvasRenderingContext2D</span> or <span>ImageBitmapRenderingContext</span> or <span>WebGLRenderingContext</span>) <dfn>RenderingContext</dfn>;

+enum <dfn>CanvasPixelFormat</dfn> {
+  "8-8-8-8", // default
+  "float16",


No trailing comma

domenic · 2018-08-23T18:19:30Z

source

@@ -60069,6 +60082,15 @@ interface <dfn>Path2D</dfn> {

   </dd>

+   <dt><var>context</var> = <var>canvas</var> . <code data-x="dom-canvas-getContext">getContext</code>('2d' [, { [ <code data-x="dom-CanvasRenderingContext2DSettings-pixelFormat">pixelFormat</code>: "float16" ] } ] )</dt>


Ugh, this really is stressing the limits our domintro pseudo-language.

I would suggest rolling this into the previous dt/dd, as they are not mutually exclusive. My suggestion is either one of

context = canvas . getContext('2d' [, { [ alpha: false ] [, pixelFormat: "float16" ] } ] )

or give up on documenting all optionality/non-defaults and do

context = canvas . getContext('2d' [, { alpha, pixelFormat } ] )

domenic · 2018-08-23T18:25:38Z

source

+
+    <dl>
+     <dt><dfn><code data-x="dom-CanvasRenderingContext2DSettings-pixelFormat">pixelFormat</code></dfn></dt>
+     <dd>Decides the backing storage for the <code data-x="dom-context-2d-canvas">canvas</code>'s


This is a description, but doesn't make any statements requiring the user agent to do anything. Some questions:

What does this impact, observably? Does it change the numeric values returned from any canvas or pixel-reading APIs?

Is "backing storage" the same as the CanvasRenderingContext2D's output bitmap?

What does "optional" mean? Does it mean fall back to 8-8-8, or throw an exception, or...?

Where is this information stored? What parts of the spec later use it?

@fserb looks like this is waiting for you to address change requests from @domenic

tabatkins · 2018-08-23T20:16:19Z

source

@@ -59318,6 +59318,17 @@ dictionary <dfn>AssignedNodesOptions</dfn> {
   <dd w-nodev>
    <pre><code class="idl" data-x="">typedef (<span>CanvasRenderingContext2D</span> or <span>ImageBitmapRenderingContext</span> or <span>WebGLRenderingContext</span>) <dfn>RenderingContext</dfn>;

+enum <dfn>CanvasPixelFormat</dfn> {
+  "8-8-8-8", // default


I presume you're using this pattern (which looks kinda odd to me, and doesn't match the structure of the other option) instead of something like int8 because we want to be open to things like 10-10-10-2 or whatever in the future?

foolip · 2018-10-30T15:41:01Z

There's an Intent to Ship: Canvas Color Management on blink-dev now, pointing back to this PR and #3926. @annevk @domenic, do either of you have the bandwidth to keep reviewing this?

@fserb, I see the "needs tests" label, do the tests in https://wpt.fyi/results/2dcontext/wide-gamut-canvas fully cover the changes in this PR, or are more needed?

chrisdavidmills · 2018-10-31T09:18:58Z

Documentation need recorded on https://trello.com/c/N0hJJV95/129-2d-canvas-api

annevk · 2018-11-06T09:08:36Z

@foolip to be clear, this PR has a number of unaddressed outstanding comments already. And I believe it also depends on #3926 which isn't moving forward either.

svgeesus · 2018-11-29T15:37:45Z

The Chrome intent to ship says

Is this feature fully tested by web-platform-tests?
Yes.

but I couldn't find the tests. A link would be helpful. I'm mainly wanting to read the tests as worked examples to help my review of the spec.

svgeesus · 2018-11-29T16:31:55Z

source

+     <dd>Decides the backing storage for the <code data-x="dom-context-2d-canvas">canvas</code>'s
+     context. Support for "8-8-8-8" is mandatory. All other formats are optional. When using "8-8-8-8",
+     one byte is used for each color channel and 1 byte used for alpha. When using float
+     formats, values outside of [0, 1] range can be used to represent colors outside of the color


This requires the transfer function to be fully specified outside [0,1].

Could I have a pointer to where that is defined?

foolip · 2018-12-03T14:29:27Z

@fserb @zakerinasab, can you point to the existing tests in WPT? Presumably they need to be updated at least a little for this change?

fserb · 2018-12-03T16:42:17Z

@foolip: this is tests we have so far:
https://github.com/web-platform-tests/wpt/tree/master/2dcontext/wide-gamut-canvas

foolip · 2018-12-03T23:08:36Z

@svgeesus, hope that helps!

svgeesus · 2018-12-17T16:47:48Z

@fserb perhaps the questions from @domenic were missed?

svgeesus · 2019-10-31T14:38:19Z

@domenic it seems the issues you raised are still unaddressed? @foolip @annevk how should this be moved forward?

annevk · 2019-10-31T18:35:46Z

Someone(s) with time would need to define the underlying model and processing model on top, as well as write the relevant tests. We have an API sketch, but none of the remainder, from a quick look and from what I remember when we last went through this.

annevk · 2021-04-28T14:04:09Z

#6562 lays some groundwork for this. Closing this as it's outdated and needs a lot more work as per the above comments.

fserb changed the title ~~Adds wide-gammut support~~ Adds wide-gamut support Aug 4, 2018

annevk added the topic: canvas label Aug 8, 2018

annevk reviewed Aug 8, 2018

View reviewed changes

fserb added 3 commits August 15, 2018 14:39

pixelFormat support

95bc57f

convertToBlob

fd8ab27

convertToBlob algorithm

0e766af

fserb force-pushed the colormgmt branch from 3f0d708 to 0e766af Compare August 15, 2018 18:40

Remove convertToBlob and cleans up 8-8-8-8 definition

a8443fb

annevk added addition/proposal New features or enhancements needs tests Moving the issue forward requires someone to write tests impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation labels Aug 16, 2018

annevk mentioned this pull request Aug 22, 2018

Adds convertToBlob to Canvas #3926

Open

domenic requested changes Aug 23, 2018

View reviewed changes

tabatkins reviewed Aug 23, 2018

View reviewed changes

fserb mentioned this pull request Oct 30, 2018

Wide gamut support for Canvas/OffscreenCanvas/ImageBitmap w3ctag/design-reviews#315

Closed

5 tasks

svgeesus suggested changes Nov 29, 2018

View reviewed changes

svgeesus mentioned this pull request Oct 31, 2019

[css-color-4] extend rgb() for HDR w3c/csswg-drafts#3249

Closed

svgeesus mentioned this pull request Dec 9, 2019

Is this still active? WICG/canvas-color-space#26

Closed

Base automatically changed from master to main January 15, 2021 07:57

annevk closed this Apr 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds wide-gamut support #3882

Adds wide-gamut support #3882

fserb commented Aug 3, 2018 •

edited by pr-preview bot

Loading

fserb commented Aug 3, 2018

smfr commented Aug 4, 2018

fserb commented Aug 4, 2018

annevk left a comment

annevk Aug 8, 2018

domenic Aug 23, 2018

annevk commented Aug 8, 2018

fserb commented Aug 15, 2018

annevk commented Aug 16, 2018

domenic left a comment

domenic Aug 23, 2018

domenic Aug 23, 2018

domenic Aug 23, 2018

svgeesus Dec 10, 2018

tabatkins Aug 23, 2018

fserb Nov 5, 2018

foolip commented Oct 30, 2018

chrisdavidmills commented Oct 31, 2018

annevk commented Nov 6, 2018

svgeesus commented Nov 29, 2018

svgeesus Nov 29, 2018

foolip commented Dec 3, 2018

fserb commented Dec 3, 2018

foolip commented Dec 3, 2018

svgeesus commented Dec 17, 2018

svgeesus commented Oct 31, 2019

annevk commented Oct 31, 2019

annevk commented Apr 28, 2021

		@@ -60069,6 +60082,15 @@ interface <dfn>Path2D</dfn> {

		</dd>

		<dt><var>context</var> = <var>canvas</var> . <code data-x="dom-canvas-getContext">getContext</code>('2d' [, { [ <code data-x="dom-CanvasRenderingContext2DSettings-pixelFormat">pixelFormat</code>: "float16" ] } ] )</dt>

Adds wide-gamut support #3882

Adds wide-gamut support #3882

Conversation

fserb commented Aug 3, 2018 • edited by pr-preview bot Loading

💥 Error: Wattsi server error 💥

fserb commented Aug 3, 2018

smfr commented Aug 4, 2018

fserb commented Aug 4, 2018

annevk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annevk commented Aug 8, 2018

fserb commented Aug 15, 2018

annevk commented Aug 16, 2018

domenic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

foolip commented Oct 30, 2018

chrisdavidmills commented Oct 31, 2018

annevk commented Nov 6, 2018

svgeesus commented Nov 29, 2018

Choose a reason for hiding this comment

foolip commented Dec 3, 2018

fserb commented Dec 3, 2018

foolip commented Dec 3, 2018

svgeesus commented Dec 17, 2018

svgeesus commented Oct 31, 2019

annevk commented Oct 31, 2019

annevk commented Apr 28, 2021

fserb commented Aug 3, 2018 •

edited by pr-preview bot

Loading