Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Fix typo in textarea cloning steps #10892

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Editorial: Fix typo in textarea cloning steps #10892

merged 1 commit into from
Jan 6, 2025

Conversation

AtkinsSJ
Copy link
Contributor

@AtkinsSJ AtkinsSJ commented Jan 5, 2025 •
edited by pr-preview bot
Loading

A small mistake I noticed while updating Ladybird's implementation.

  • At least two implementers are interested (and none opposed):
    • …
    • …
  • Tests are written and can be reviewed and commented upon at:
    • …
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
  • Corresponding HTML AAM & ARIA in HTML issues & PRs:
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

/form-elements.html ( diff )

AtkinsSJ added a commit to AtkinsSJ/ladybird that referenced this pull request Jan 5, 2025
@AtkinsSJ
LibWeb/HTML: Update cloning steps to current spec algorithms
8fb7c70 
Reflects the changes in whatwg/html#10859

I've also added missing calls to the Base::cloned() method, and modified
a couple of spec links to point to the multipage version.

I took the liberty to fix a spec typo, and submitted a PR for it:
whatwg/html#10892
tcl3 pushed a commit to LadybirdBrowser/ladybird that referenced this pull request Jan 5, 2025
@AtkinsSJ @tcl3
LibWeb/HTML: Update cloning steps to current spec algorithms
2e96ba1 
Reflects the changes in whatwg/html#10859

I've also added missing calls to the Base::cloned() method, and modified
a couple of spec links to point to the multipage version.

I took the liberty to fix a spec typo, and submitted a PR for it:
whatwg/html#10892
annevk
annevk approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@annevk annevk merged commit 8e95516 into whatwg:main Jan 6, 2025
2 checks passed
@AtkinsSJ AtkinsSJ deleted the element-clone-typo branch January 6, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AtkinsSJ @annevk