Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added env parser inside the library #24

Merged
merged 18 commits into from
Jan 18, 2025

Conversation

coderx31
Copy link
Collaborator

Guidelines

  1. Please complete the below template before submitting the PR. PR will be rejected if this is not completed.
  2. Please tag issue number to title. Example: [01] New Feature X
  3. Please do not modify the template.

Description

Please include a summary of the changes and the related issue.

List any dependencies that are required for this change.

Introduced new function to wrap the env.Parse function. Therefore "github.com/caarlos0/env/v11"
no longer will be a direct dependency for users

Issue

Please provide the relevant issue link.
#17

Type of change

Please mark [ x ] which are relevant.

  • [ ] Bug fix (non-breaking change which fixes the issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality)
  • [ ] This change requires a documentation update

Checklist

  • [ x ] I have added the issue number and link to this PR.
  • [ x ] My PR is only for one issue. If not please mention all the issues above.
  • [ x ] My code follows the style guidelines of this project
  • [ x ] I have performed a self-review of my code
  • [ x ] I have commented my code, particularly in hard-to-understand areas
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] My changes generates no new warnings
  • [ x ] I have added tests that prove my fix is effective or my feature works
  • [ x ] New and existing unit tests pass locally with my changes

Test Summary / Screenshots

Please provide the test summary and necessary screenshots
locally testing results
Screenshot 2025-01-15 at 20 00 02

unit tests results
Screenshot 2025-01-15 at 20 01 03

@wgarunap wgarunap linked an issue Jan 15, 2025 that may be closed by this pull request
Copy link
Owner

@wgarunap wgarunap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! needs small improvements on the tests.

parse.go Outdated Show resolved Hide resolved
parse_test.go Outdated Show resolved Hide resolved
parse_test.go Outdated Show resolved Hide resolved
@wgarunap
Copy link
Owner

suggest to have a PR name like Added env parser inside the library, no need to mention the issue id as we already linked the PR with the issue. @coderx31

@wgarunap wgarunap added the enhancement New feature or request label Jan 15, 2025
@coderx31 coderx31 changed the title [#17] wrap env loading inside library implementation with unit tests [#17] Added env parser inside the library Jan 17, 2025
@coderx31 coderx31 requested a review from wgarunap January 17, 2025 07:10
@wgarunap wgarunap changed the title [#17] Added env parser inside the library Added env parser inside the library Jan 17, 2025
parse_test.go Outdated Show resolved Hide resolved
@wgarunap wgarunap merged commit 6404bb9 into wgarunap:master Jan 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap env loading inside the library
2 participants