-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added env parser inside the library #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alues config value masking feature added
wgarunap
reviewed
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! needs small improvements on the tests.
suggest to have a PR name like |
wgarunap
reviewed
Jan 15, 2025
coderx31
changed the title
[#17] wrap env loading inside library implementation with unit tests
[#17] Added env parser inside the library
Jan 17, 2025
wgarunap
changed the title
[#17] Added env parser inside the library
Added env parser inside the library
Jan 17, 2025
wgarunap
reviewed
Jan 17, 2025
wgarunap
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines
Description
Please include a summary of the changes and the related issue.
List any dependencies that are required for this change.
Introduced new function to wrap the env.Parse function. Therefore "github.com/caarlos0/env/v11"
no longer will be a direct dependency for users
Issue
Please provide the relevant issue link.
#17
Type of change
Please mark [ x ] which are relevant.
Checklist
Test Summary / Screenshots
Please provide the test summary and necessary screenshots
locally testing results
unit tests results