Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experimental solady erc1271 sign actions #2413

Merged
merged 12 commits into from
Jun 19, 2024
Merged

feat: experimental solady erc1271 sign actions #2413

merged 12 commits into from
Jun 19, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Jun 15, 2024

Adding support for Solady flavoured ERC-1271 signMessage & signTypedData for Smart Accounts that implement (or conform to) Solady's ERC1271.sol (e.g. Coinbase Smart Wallet, Light Account, etc).


PR-Codex overview

This PR introduces Solady flavored ERC-1271 actions for signing messages and typed data, updates utility functions, adds sidebar links, and enhances verification logic.

Detailed summary

  • Added signMessage and signTypedData actions for Solady
  • Updated toPrefixedMessage utility function
  • Added sidebar links for Solady actions
  • Enhanced verification logic for hash and typed data
  • Updated package size limits in package.json

The following files were skipped due to too many changes: src/experimental/solady/decorators/solady.test.ts, src/experimental/solady/actions/signMessage.test.ts, src/experimental/solady/actions/signMessage.ts, site/pages/experimental/solady/signMessage.md, src/experimental/solady/decorators/solady.ts, src/experimental/solady/actions/signTypedData.ts, src/experimental/solady/actions/signTypedData.test.ts, src/actions/public/verifyHash.test.ts, site/pages/experimental/solady/signTypedData.md

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Jun 18, 2024 10:45pm

Copy link

changeset-bot bot commented Jun 15, 2024

🦋 Changeset detected

Latest commit: 02d11b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (4b92979) to head (02d11b7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2413      +/-   ##
==========================================
+ Coverage   99.61%   99.63%   +0.01%     
==========================================
  Files         687      692       +5     
  Lines       58030    58839     +809     
  Branches     2807     2824      +17     
==========================================
+ Hits        57809    58622     +813     
+ Misses        206      202       -4     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 15, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 59.01 KB (+0.27% 🔺) 1.2 s (+0.27% 🔺) 1.2 s (+25.37% 🔺) 2.4 s
viem (cjs) 70.24 KB (+0.23% 🔺) 1.5 s (+0.23% 🔺) 2.2 s (+4.02% 🔺) 3.6 s
viem (minimal surface - tree-shaking) 6.09 KB (0%) 122 ms (0%) 28 ms (-55.15% 🔽) 150 ms
viem/accounts 73.99 KB (+0.2% 🔺) 1.5 s (+0.2% 🔺) 454 ms (-24.62% 🔽) 2 s
viem/accounts (tree-shaking) 18.94 KB (+0.08% 🔺) 379 ms (+0.08% 🔺) 283 ms (-0.27% 🔽) 661 ms
viem/actions 45.28 KB (0%) 906 ms (0%) 428 ms (+16.61% 🔺) 1.4 s
viem/actions (tree-shaking) 318 B (0%) 10 ms (0%) 5 ms (+26.43% 🔺) 15 ms
viem/chains 28.62 KB (0%) 573 ms (0%) 597 ms (-25.35% 🔽) 1.2 s
viem/chains (tree-shaking) 324 B (0%) 10 ms (0%) 7 ms (+45.55% 🔺) 17 ms
viem/chains/utils 1.02 KB (0%) 21 ms (0%) 9 ms (-36.35% 🔽) 30 ms
viem/ens 45.28 KB (0%) 906 ms (0%) 450 ms (-23.95% 🔽) 1.4 s
viem/ens (tree-shaking) 21.97 KB (0%) 440 ms (0%) 537 ms (+35.5% 🔺) 976 ms
viem/siwe 29.95 KB (+0.77% 🔺) 599 ms (+0.77% 🔺) 606 ms (+22.17% 🔺) 1.3 s
viem/siwe (tree-shaking) 28.82 KB (+0.71% 🔺) 577 ms (+0.71% 🔺) 657 ms (+103.27% 🔺) 1.3 s

@jxom jxom merged commit 99ed745 into main Jun 19, 2024
34 checks passed
@jxom jxom deleted the solady branch June 19, 2024 01:09
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant