-
-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deployless call via bytecode #2408
Conversation
🦋 Changeset detectedLatest commit: 13750b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2408 +/- ##
=======================================
Coverage 99.61% 99.62%
=======================================
Files 684 684
Lines 57609 57658 +49
Branches 2784 2789 +5
=======================================
+ Hits 57390 57440 +50
- Misses 203 204 +1
+ Partials 16 14 -2 ☔ View full report in Codecov by Sentry. |
src/actions/public/call.ts
Outdated
} | ||
| { | ||
/** Bytecode to perform the call on. */ | ||
bytecode?: Hex | undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call this code
instead of bytecode
? Aligns better with Ethereum terminology 'eth_getCode'
(the getBytecode
action should probably be called getCode
too).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah let’s do it. Guess it also consistent with code
in state overrides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7550884
to
870c6ca
Compare
Adding ability to perform a deployless contract call via bytecode.
PR-Codex overview
This PR introduces Deployless Call patterns via bytecode and factory. It enhances contract interaction and testing capabilities.
Detailed summary
writeContract
andreadContract
simulateContract
andwriteContract
updatesCounterfactualDeploymentFailedError
constructor to handle optional factory addressdeployless
flag inContractFunctionReturnType
for deployless callsreadContract.md