GCWeb Jekyll - Ability to import script of type module w/ front-matter #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garneauma
requested changes
Feb 24, 2025
|
Pre-approved upon successful testing. |
Garneauma
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to GCWeb Jekyll options and does not affect the distribution files, and it does not require a release to take effect. as the CD updates GCWeb Jekyll upon merging.
It allows for importing on a page scripts of various types, such as
module.This will enable running test pages with the GCWeb Jekyll theme for GC Search UI.
I have added working examples throug a PR in the GCWeb Jekyll website sample. When merged, example of success is that this page shows "Hello world from module" in the grey well: https://wet-boew.github.io/gcweb-jekyll-website/advanced/add-script-module.html
Related to SR-454