-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributors: move to sites, change context of use #2459
Open
Garneauma
wants to merge
1
commit into
wet-boew:master
Choose a base branch
from
Garneauma:gc-contributors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-approved upon successful review. |
duboisp
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Todo:
- Centralize sample inside the contributor component.
- (Optional) remove the "gc-" prefix in the file/folder name for the contributor component
- Update the contributor component documentation to add more emphasis on the breaking change + migration instruction.
- Page details - move demoted pattern in demoted folder
- For "contributor" component, make it a minor version for now (v1.1) because both are still ok, but identify the version 1.0 as demoted. We will increase the major version when we will switch the v1.0 from "demoted" into "deprecated" state.
This change is:
- Minor change for contributor component - Add new pattern where located in the page details section
- Minor change for page details component - Add new pattern that include the contributor component
- Minor change for Topic template - Add new pattern that include the new page details with the contributor component
- Minor change for the "Topic" template - Add new pattern that implement page-details v 3.3 where the contributor component are in the page-details section
- We will perform a major change to those component, when we will switch them from "demoted" into "deprecated" at our next major release
Garneauma
force-pushed
the
gc-contributors
branch
from
January 30, 2025 19:43
381df46
to
84339ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to WET-505