Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors: move to sites, change context of use #2459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Garneauma
Copy link
Contributor

  • Moved Cotnributors component to Sites section
  • Updated Page details component to include Contributors component
  • Updated Topic template with new Contributors location

Related to WET-505

@Garneauma
Copy link
Contributor Author

Pre-approved upon successful review.

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo:

  • Centralize sample inside the contributor component.
  • (Optional) remove the "gc-" prefix in the file/folder name for the contributor component
  • Update the contributor component documentation to add more emphasis on the breaking change + migration instruction.
  • Page details - move demoted pattern in demoted folder
  • For "contributor" component, make it a minor version for now (v1.1) because both are still ok, but identify the version 1.0 as demoted. We will increase the major version when we will switch the v1.0 from "demoted" into "deprecated" state.

This change is:

  • Minor change for contributor component - Add new pattern where located in the page details section
  • Minor change for page details component - Add new pattern that include the contributor component
  • Minor change for Topic template - Add new pattern that include the new page details with the contributor component
  • Minor change for the "Topic" template - Add new pattern that implement page-details v 3.3 where the contributor component are in the page-details section
  • We will perform a major change to those component, when we will switch them from "demoted" into "deprecated" at our next major release

_includes/sites/gc-contributors/gc-contributors.html Outdated Show resolved Hide resolved
sites/gc-contributors/index.json-ld Outdated Show resolved Hide resolved
sites/gc-contributors/index.json-ld Outdated Show resolved Hide resolved
sites/gc-contributors/index.json-ld Outdated Show resolved Hide resolved
sites/gc-contributors/index.json-ld Outdated Show resolved Hide resolved
templates/topic/deprecated/topic_v2-en.html Outdated Show resolved Hide resolved
templates/topic/deprecated/topic_v2-fr.html Outdated Show resolved Hide resolved
templates/topic/index.json-ld Outdated Show resolved Hide resolved
templates/topic/index.json-ld Show resolved Hide resolved
templates/topic/index.json-ld Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants