Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

News: updating news template #2458

Merged
merged 1 commit into from
Feb 4, 2025
Merged

News: updating news template #2458

merged 1 commit into from
Feb 4, 2025
+225 −168

Conversation

Garneauma
Copy link
Contributor

@Garneauma Garneauma commented Dec 19, 2024 •
edited by duboisp
Loading

  • Updating paragraphs above and below the news table.
  • Adding instructions on what to do in basic HTML mode.

(wet-496)

@Garneauma
Copy link
Contributor Author

Pre-approved upon successful review and approval by the News team.

@duboisp duboisp self-assigned this Dec 30, 2024
@duboisp duboisp self-requested a review December 30, 2024 15:08
@Garneauma
Copy link
Contributor Author

Pre-approved upon successful review.

duboisp
duboisp approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, this look good.

this is a Patch.

But prior to merge this, @Ricokola need to do some verification first.

duboisp
duboisp requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for @Ricokola check

Ricokola
Ricokola requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Ricokola Ricokola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approved upon fixing a minor typo in news-en.html

@duboisp duboisp assigned Garneauma and unassigned duboisp Jan 15, 2025
@Garneauma Garneauma assigned duboisp and unassigned Garneauma Jan 28, 2025
duboisp
duboisp approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

@duboisp duboisp removed their assignment Feb 3, 2025
@duboisp duboisp added this to the v16.2.0 milestone Feb 3, 2025
Ricokola
Ricokola approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@Ricokola Ricokola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems completed and good to go!

@Garneauma Garneauma merged commit 7b3646a into wet-boew:master Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duboisp duboisp

@Ricokola Ricokola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v16.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Garneauma @duboisp @Ricokola