Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byline: adding documentation, moving to main title #2452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Garneauma
Copy link
Contributor

@Garneauma Garneauma commented Dec 11, 2024

  • Adding byline documentation so that it can be deprecated
  • Adding "Main page title with byline" variation to the Main page title (this variation is limited to news pages on Canada.ca)

Related to WET-494

@Garneauma
Copy link
Contributor Author

@duboisp I have set the status of the byline component to deprecated. However, if we want to get this pull request out without triggering a major release, I can change it to demoted instead.

@Garneauma
Copy link
Contributor Author

Pre-approved upon successful review.

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment inline.

Note: We will need to discuss if we apply that by default to the last paragraph in the hgroup or if we require this to be activated by the author by using a CSS class. The second option will allow us to use the paragraph under the h1 for something else considering that the trial currently is to remove the byline.

components/byline/index.json-ld Outdated Show resolved Hide resolved
components/byline/index.json-ld Outdated Show resolved Hide resolved
components/byline/index.json-ld Outdated Show resolved Hide resolved
components/byline/index.json-ld Outdated Show resolved Hide resolved
components/byline/index.json-ld Outdated Show resolved Hide resolved
sites/main-page-title/_base.scss Outdated Show resolved Hide resolved
sites/main-page-title/index.json-ld Outdated Show resolved Hide resolved
sites/main-page-title/index.json-ld Outdated Show resolved Hide resolved
sites/main-page-title/index.json-ld Outdated Show resolved Hide resolved
@duboisp duboisp assigned Garneauma and unassigned duboisp Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants