GC-Subway: fixing skip link hrefà

wet-boew · Nov 30, 2023 · 7c22b49 · 7c22b49
1 parent 74b26eb
commit 7c22b49
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/components/gc-subway/_screen-md-min.scss b/components/gc-subway/_screen-md-min.scss
@@ -15,6 +15,8 @@
 
 		border-color: transparent;
 		display: none;
+		margin-top: 0;
+		padding-top: 2em;
 
 		.wb-disable & {
 			display: block;
@@ -23,7 +25,7 @@
 		hgroup {
 			left: -.5em;
 			position: absolute;
-			top: -2em;
+			top: 0;
 
 			h1 {
 				clip: rect(1px, 1px, 1px, 1px);

diff --git a/components/gc-subway/gc-subway.js b/components/gc-subway/gc-subway.js
@@ -47,8 +47,7 @@ var $document = wb.doc,
 
 				// Add skip link to sections list
 				if ( $navH1 ) {
-					$navH1.id = $navH1.id || wb.getId(); // Ensure the element has an ID
-					wb.addSkipLink( wb.i18n( "skip-prefix" ) + " " + $navH1.text(), { href: "#" + $navH1.id } );
+					wb.addSkipLink( wb.i18n( "skip-prefix" ) + " " + $navH1.text(), { href: "#" + elm.id } );
 				}
 
 				// Wrap all content until it hits either: ".pagedetails", or "".gc-subway-support"