Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WwwRedirectMiddleware for redirecting www to bare domain #106

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

joshuadavidthomas
Copy link
Member

No description provided.

@joshuadavidthomas joshuadavidthomas requested a review from a team as a code owner August 30, 2024 15:47
Copy link

@jefftriplett jefftriplett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slept on this one. The code is good, but I'm not sure why we need it in a Cloudflare world.

@joshuadavidthomas
Copy link
Member Author

@jefftriplett Eh, I forget my exact thought process that led to this. As I think about it now, it's maybe just as simple as one less page rule to create for a domain in Cloudflare. Just create DNS records for @ and www and point them both to the application.

@joshuadavidthomas joshuadavidthomas merged commit 5749968 into main Sep 4, 2024
18 checks passed
@joshuadavidthomas joshuadavidthomas deleted the www-redirect branch September 4, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants