Fixed nokogiri/Xalan crash under jruby. #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nokogiri for java (Xalan) didn't like calls so document.create_element where the name contained a namespace prefix. Now Fixed. Had to slightly change write_xml internal behavior (new elements are immediately added to parent) to enable proper element lookups.
ognen
force-pushed
the
jruby-namespace-fix
branch
from
9600824 to
3707446
Compare
|
Would you please make the version of the patch that contains only the fix? No re-indentation, no variable name changes — just the code that fixes the problem? I can't review this for validity when 80% of the changes you made are not actually functional changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nokogiri for java (Xalan) didn't like calls so
where the name contained a namespace prefix. Now Fixed.
Had to slightly change write_xml internal behavior (new elements are
immediately added to parent) to enable proper element lookups.
(you can see these crashes if you run
rake specunder jruby 1.7.16.1).