Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2.0 #97

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Release 2.2.0 #97

merged 5 commits into from
Nov 1, 2024

Conversation

aletail
Copy link
Member

@aletail aletail commented Oct 31, 2024

Summary

Release 2.2.0

Testing Steps

  • Test again (optional)
  • Review release notes

Git Flow

  • DO NOT delete "release/*" or "hotfix/*" branches after merging a PR. These are used to publish the next release, and they are deleted automatically.
  • "Squash and merge" is good on "feature/*" into "develop"
  • "Create a merge commit" is good on "release/*" or "hotfix/*" into "main"
  • With npm repositories, the version number must be incremented manually, before merging the release.

@aletail aletail requested a review from tiller1010 October 31, 2024 17:59
@aletail aletail added the minor label Oct 31, 2024
Copy link
Member

@tiller1010 tiller1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I think we might want something like a labelAboveMargin property in $component-form-properties though. I tested this in bridges exp, and the labels touched the form fields in the footer.

The xmc line height on the body prevents this issue on that site.

@aletail aletail requested a review from tiller1010 November 1, 2024 15:56
Copy link
Member

@tiller1010 tiller1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@aletail aletail merged commit 9161443 into main Nov 1, 2024
1 check passed
aletail added a commit that referenced this pull request Nov 1, 2024
Merge pull request #97 from werkbot/release/2.2.0
@aletail aletail mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants