Added the notes change for 3.0.0 + removed comments

weierophinney · Mar 11, 2019 · 6df64e0 · 6df64e0
1 parent 2e1ec17
commit 6df64e0
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 27 deletions.
diff --git a/3.0.0.md b/3.0.0.md
@@ -18,3 +18,13 @@ We cannot use type hint because the usage of `Zend\ServiceManager\FactoryInterfa
 - Zend\Db\Adapter\ParameterContainer
 
 Removed `merge()`, added `mergeFromArray()` and `mergeFromParameterContainer()`.
+
+- Zend\Db\Adapter\Platform
+
+Changed `setDriver(DriverInterface $driver)` for all the following platforms:
+
+    - Zend\Db\Adapter\Platform\Mysql
+    - Zend\Db\Adapter\Platform\Oracle
+    - Zend\Db\Adapter\Platform\Postgresql
+    - Zend\Db\Adapter\Platform\Sqlite
+    - Zend\Db\Adapter\Platform\SqlServer
diff --git a/src/Adapter/Platform/Mysql.php b/src/Adapter/Platform/Mysql.php
@@ -44,18 +44,8 @@ public function __construct(DriverInterface $driver = null)
         }
     }
 
-    /**
-     * @return self Provides a fluent interface
-     */
     public function setDriver(DriverInterface $driver): Mysql
     {
-        // handle Zend\Db drivers
-        // if ($driver instanceof Mysqli\Mysqli
-        //     || ($driver instanceof Pdo\Pdo && $driver->getDatabasePlatformName() == 'Mysql')
-        //     || ($driver instanceof \mysqli)
-        //     || ($driver instanceof \PDO && $driver->getAttribute(\PDO::ATTR_DRIVER_NAME) == 'mysql')
-        // ) {
-
         $this->resource = $driver;
         return $this;
     }

diff --git a/src/Adapter/Platform/Oracle.php b/src/Adapter/Platform/Oracle.php
@@ -34,17 +34,8 @@ public function __construct(array $options = [], DriverInterface $driver = null)
         }
     }
 
-    /**
-     * @return self Provides a fluent interface
-     */
     public function setDriver(DriverInterface $driver): Oracle
     {
-        // if ($driver instanceof Oci8
-        //     || ($driver instanceof Pdo && $driver->getDatabasePlatformName() == 'Oracle')
-        //     || ($driver instanceof Pdo && $driver->getDatabasePlatformName() == 'Sqlite')
-        //     || ($driver instanceof \oci8)
-        //     || ($driver instanceof PDO && $driver->getAttribute(PDO::ATTR_DRIVER_NAME) == 'oci')
-        // ) {
         $this->resource = $driver;
         return $this;
     }

diff --git a/src/Adapter/Platform/Postgresql.php b/src/Adapter/Platform/Postgresql.php
@@ -33,16 +33,8 @@ public function __construct(DriverInterface $driver = null)
         }
     }
 
-    /**
-     * @return self Provides a fluent interface
-     */
     public function setDriver(DriverInterface $driver): Postgresql
     {
-        // if ($driver instanceof Pgsql\Pgsql
-        //     || ($driver instanceof Pdo\Pdo && $driver->getDatabasePlatformName() == 'Postgresql')
-        //     || (is_resource($driver) && (in_array(get_resource_type($driver), ['pgsql link', 'pgsql link persistent'])))
-        //     || ($driver instanceof \PDO && $driver->getAttribute(\PDO::ATTR_DRIVER_NAME) == 'pgsql')
-        // ) {
         $this->resource = $driver;
         return $this;
     }