Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”οΈ Rename query parameter descriptionEditable to custom_description #457

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

wei
Copy link
Owner

@wei wei commented Dec 19, 2024

Fixes #275

Rename descriptionEditable to custom_description with backwards compatibility.

  • Rename descriptionEditable to custom_description in common/types/queryType.ts.
  • Rename descriptionEditable to custom_description in src/components/configuration/config.tsx.
  • Add backwards compatibility check for descriptionEditable in src/components/configuration/config.tsx.
  • Rename descriptionEditable to custom_description in common/configHelper.ts.
  • Add backwards compatibility check for descriptionEditable in common/configHelper.ts.

For more details, open the Copilot Workspace session.

Copy link

changeset-bot bot commented Dec 19, 2024

πŸ¦‹ Changeset detected

Latest commit: 5d4e2fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
socialify Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Dec 19, 2024

βœ… Deploy Preview for github-socialify ready!

Name Link
πŸ”¨ Latest commit 5d4e2fc
πŸ” Latest deploy log https://app.netlify.com/sites/github-socialify/deploys/676397584ca8df00086f4449
😎 Deploy Preview https://deploy-preview-457--github-socialify.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wei wei force-pushed the rename-description-param branch from d31b849 to 1661910 Compare December 19, 2024 03:47
Fixes #275

Rename `descriptionEditable` to `custom_description` with backwards compatibility.

* Rename `descriptionEditable` to `custom_description` in `common/types/queryType.ts`.
* Rename `descriptionEditable` to `custom_description` in `src/components/configuration/config.tsx`.
* Add backwards compatibility check for `descriptionEditable` in `src/components/configuration/config.tsx`.
* Rename `descriptionEditable` to `custom_description` in `common/configHelper.ts`.
* Add backwards compatibility check for `descriptionEditable` in `common/configHelper.ts`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/wei/socialify/issues/275?shareId=XXXX-XXXX-XXXX-XXXX).
@wei wei force-pushed the rename-description-param branch from 1661910 to 5d4e2fc Compare December 19, 2024 03:47
@wei wei changed the title πŸ”οΈ Rename url parameter descriptionEditable to custom_description πŸ”οΈ Rename query parameter descriptionEditable to custom_description Dec 19, 2024
@wei wei enabled auto-merge (squash) December 19, 2024 03:51
@wei wei disabled auto-merge December 19, 2024 03:51
@wei wei merged commit c7d053d into master Dec 19, 2024
9 checks passed
@wei wei deleted the rename-description-param branch December 19, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename descriptionEditable to custom_description with backwards compatibility
1 participant