Fix max count for subregions #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwhite
force-pushed
the
subregion-fix
branch
2 times, most recently
from
2a436ee to
88ece56
Compare
This is currently failing for me locally
ethanwhite
force-pushed
the
subregion-fix
branch
from
88ece56 to
62f8f60
Compare
The use of .data was causing errors due to use of `$` when specifying single column
names not being allowed and likely further down the pipe as well. This removes use
of .data in the section of the code triggerd by level = "subregion".
It also fixes a problem caused by using bind_rows with different named columns
("region" in one table, "subregion" in another table).
The goal was to maintain the behavior of the function as written, but I think
there is also a conversation to be had about how level = "subregion" results in
data source mixing that may be unintuitive to users and should be clearly
documented.
ethanwhite
changed the title
gmyenni
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently failing for me locally