Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn contributors about PRs from forks in tests [no version bump] #542

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

ethanwhite
Copy link
Member

Due to the use of secrets in tests will not pass if submitted via PRs from forks. These failures can be quite confusing.
To reduce confusion this adds up step to the GH actions workflow that will fail informatively if running on a PR from a fork.

Due to the use of secrets in tests will not pass if submitted via PRs from forks.
These failures can be quite confusing.
To reduce confusion this adds up step to the GH actions workflow that will fail
informatively if running on a PR from a fork.
@ethanwhite ethanwhite requested a review from henrykironde July 20, 2024 18:56
@ethanwhite
Copy link
Member Author

See #541 for a demonstration that this fails when submitting from a fork.

@henrykironde henrykironde merged commit 0180abd into main Jul 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants