Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bufferutil as optional dependency #213

Merged
merged 1 commit into from
Mar 7, 2017
Merged

add bufferutil as optional dependency #213

merged 1 commit into from
Mar 7, 2017

Conversation

lpinca
Copy link
Contributor

@lpinca lpinca commented Mar 3, 2017

bufferutil greatly improves ws performance.
The package now has prebuilt binaries for Node.js 4, 6 and 7 (darwin, win32 and linux).

This should help with #175.

Slightly off-topic: memory usage can be reduced by ~15% if ws.upgradeReq is freed when it is no longer needed.

feross
feross approved these changes Mar 7, 2017
View reviewed changes
Copy link
Member

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the great feedback!

@feross feross merged commit 5b05a43 into webtorrent:master Mar 7, 2017
@lpinca lpinca deleted the bufferutil branch March 7, 2017 21:11
@feross
Copy link
Member

feross commented Mar 7, 2017

Released as 9.0.1.

@lpinca As for your ws.upgradeReq comment, could you take a look at this PR and share your thoughts? Thanks! #215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feross feross feross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpinca @feross @dpxcc