Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix The Issue #176 #177

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+100 −0
Open

Fix The Issue #176 #177

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43912bf
fix: Pass Error Object to Callback When Reject A Falsy Value, fix iss…
Solo-steven Oct 11, 2022
df245db
fix: Delete Unnecessary Semi and Change Line In Snapshot.
Solo-steven Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Delete Unnecessary Semi and Change Line In Snapshot.
@Solo-steven
Solo-steven committed Oct 11, 2022
commit df245dbafc8540de400e9e9fb52526475f20698e
2 changes: 1 addition & 1 deletion lib/HookCodeFactory.js
View file
Original file line number Diff line number Diff line change
@@ -266,7 +266,7 @@ class HookCodeFactory {
}
code += `}), function(_err${tapIndex}) {\n`;
code += `if(_hasResult${tapIndex}) throw _err${tapIndex};\n`;
code += `if(!_err${tapIndex}) { ${onError(`new Error()`)};\n`
code += `if(!_err${tapIndex}) { ${onError(`new Error()`)}`
code += `return; }\n`;
code += onError(`_err${tapIndex}`);
code += "});\n";
15 changes: 0 additions & 15 deletions lib/__tests__/__snapshots__/HookCodeFactory.js.snap
View file
Original file line number Diff line number Diff line change
@@ -60,7 +60,6 @@ onResult(_result2);
}), function(_err2) {
if(_hasResult2) throw _err2;
if(!_err2) { onError(new Error());
;
return; }
onError(_err2);
});
@@ -106,7 +105,6 @@ onDone();
}), function(_err2) {
if(_hasResult2) throw _err2;
if(!_err2) { onError(new Error());
;
return; }
onError(_err2);
});
@@ -260,7 +258,6 @@ onResult(_result2);
}), function(_err2) {
if(_hasResult2) throw _err2;
if(!_err2) { onError(new Error());
;
return; }
onError(_err2);
});
@@ -306,7 +303,6 @@ onDone();
}), function(_err2) {
if(_hasResult2) throw _err2;
if(!_err2) { onError(new Error());
;
return; }
onError(_err2);
});
@@ -475,7 +471,6 @@ onResult(_result2);
}), function(_err2) {
if(_hasResult2) throw _err2;
if(!_err2) { onError(new Error());
;
return; }
onError(_err2);
});
@@ -527,7 +522,6 @@ onDone();
}), function(_err2) {
if(_hasResult2) throw _err2;
if(!_err2) { onError(new Error());
;
return; }
onError(_err2);
});
@@ -661,7 +655,6 @@ onDone();
}), function(_err2) {
if(_hasResult2) throw _err2;
if(!_err2) { onError(2, new Error());
;
return; }
onError(2, _err2);
});
@@ -830,7 +823,6 @@ if(_hasResult2) throw _err2;
if(!_err2) { if(_counter > 0) {
onError(2, new Error());
}
;
return; }
if(_counter > 0) {
onError(2, _err2);
@@ -946,7 +938,6 @@ onDone();
}), function(_err2) {
if(_hasResult2) throw _err2;
if(!_err2) { onError(2, new Error());
;
return; }
onError(2, _err2);
});
@@ -1081,7 +1072,6 @@ _next1();
}), function(_err1) {
if(_hasResult1) throw _err1;
if(!_err1) { onError(1, new Error());
;
return; }
onError(1, _err1);
});
@@ -1227,7 +1217,6 @@ if(_hasResult1) throw _err1;
if(!_err1) { if(_counter > 0) {
onError(1, new Error());
}
;
return; }
if(_counter > 0) {
onError(1, _err1);
@@ -1371,7 +1360,6 @@ onDone();
}), function(_err1) {
if(_hasResult1) throw _err1;
if(!_err1) { onError(1, new Error());
;
return; }
onError(1, _err1);
});
@@ -1872,7 +1860,6 @@ onDone();
}), function(_err0) {
if(_hasResult0) throw _err0;
if(!_err0) { onError(0, new Error());
;
return; }
onError(0, _err0);
});
@@ -1942,7 +1929,6 @@ onDone();
}), function(_err0) {
if(_hasResult0) throw _err0;
if(!_err0) { onError(0, new Error());
;
return; }
onError(0, _err0);
});
@@ -2001,7 +1987,6 @@ onDone();
}), function(_err0) {
if(_hasResult0) throw _err0;
if(!_err0) { onError(0, new Error());
;
return; }
onError(0, _err0);
});