Update to match ArrayAccess interface for PHP 8.0
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc0Vu
reviewed
Apr 28, 2023
| @@ -23,7 +23,7 @@ | |||
| } | |||
| }, | |||
| "require": { | |||
| "PHP": "^7.1|^8.0", | |||
There was a problem hiding this comment.
We probably need to support old version of php.
sc0Vu
reviewed
Apr 28, 2023
There was a problem hiding this comment.
@curio-david Thanks! The code changed a lot, I'll check code formatter.
|
Hi, is this update live? Im facing the same issue with PHP 8.1 when a transaction is signed. Return type of Web3p\EthereumTx\Transaction::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the error I get from PHP 8.1