De-flake two animated custom property WPTs #49870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two tests use a duration of 1000s and a delay of -500s to effectively start the animation at 50%. That's fine, but we're not necessarily guaranteed that the animation hasn't progressed at the time we're making the test assertions. Therefore, make the animations initially "paused". Making an animation initially paused can sometimes void a test, if relevant behavior can only be exercised by a *playing* animation. However, that is not an issue for these tests, since they primarily care about cascade interaction which isn't affected by playing/paused. Fixed: 385790290, 385816384 Change-Id: I409101af17670316aba7b0faa9104fc14dd3e755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6119955 Reviewed-by: Steinar H Gunderson <[email protected]> Commit-Queue: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1401736}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6119955
branch
from
d424e41 to
2471f08
Compare
wpt-pr-bot
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two tests use a duration of 1000s and a delay of -500s
to effectively start the animation at 50%. That's fine, but we're
not necessarily guaranteed that the animation hasn't progressed
at the time we're making the test assertions. Therefore, make
the animations initially "paused".
Making an animation initially paused can sometimes void a test,
if relevant behavior can only be exercised by a playing animation.
However, that is not an issue for these tests, since they primarily
care about cascade interaction which isn't affected by playing/paused.
Fixed: 385790290, 385816384
Change-Id: I409101af17670316aba7b0faa9104fc14dd3e755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6119955
Reviewed-by: Steinar H Gunderson <[email protected]>
Commit-Queue: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1401736}