Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for TextTrackCue ctor and cue + cuebackground global attrs #42243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tests for TextTrackCue ctor and cue + cuebackground global attrs #42243

wants to merge 1 commit into from

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Sep 29, 2023 •
edited
Loading

Tests for whatwg/html#9771

Noting these tests were reviewed upstream as part of WebKit PR 18176

Sending them here for additional review in case we want to make any changes.

@marcoscaceres marcoscaceres mentioned this pull request Sep 29, 2023
Open
4 tasks
annevk
annevk reviewed Sep 29, 2023
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be a framework somewhere in WPT to test reflected attributes which you could use. Otherwise this looks pretty solid to me for the API side of things. Is styling covered separately?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

@domenic domenic Awaiting requested review from domenic

@foolip foolip Awaiting requested review from foolip

@hayatoito hayatoito Awaiting requested review from hayatoito

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@kojiishi kojiishi Awaiting requested review from kojiishi

@rniwa rniwa Awaiting requested review from rniwa

@snuggs snuggs Awaiting requested review from snuggs

@TakayoshiKochi TakayoshiKochi Awaiting requested review from TakayoshiKochi

At least 1 approving review is required to merge this pull request.

Assignees

@TakayoshiKochi TakayoshiKochi

Labels
custom-elements html wg-webplatform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcoscaceres @annevk @TakayoshiKochi @wpt-pr-bot