Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showPicker() method to HTMLSelectElement interface #42091

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Add showPicker() method to HTMLSelectElement interface #42091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions html/semantics/forms/the-select-element/resources/show-picker-child-iframe.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<!DOCTYPE html>
<title>Test showPicker() in an iframe</title>
<script type=module>
const urlParams = new URLSearchParams(location.search);
const documentDomain = urlParams.get('documentDomain');
if (documentDomain) {
document.domain = documentDomain;
}

let securityErrors = [];
const select = document.createElement("select");
try {
select.showPicker();
} catch (error) {
if (error instanceof DOMException && error.name == 'SecurityError') {
securityErrors.push("select");
}
}
parent.postMessage(securityErrors.join(','), "*");
</script>
79 changes: 79 additions & 0 deletions html/semantics/forms/the-select-element/show-picker-cross-origin-iframe.tentative.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
<!DOCTYPE html>
<title>Test showPicker() called from cross-origin iframe</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/common/get-host-info.sub.js"></script>
<body>
<iframe id="iframe1"></iframe>
<iframe id="iframe2"></iframe>
<iframe id="iframe3"></iframe>
<iframe id="iframe4"></iframe>
</body>
<script>
function waitForSecurityErrors() {
return new Promise((resolve) => {
window.addEventListener("message", (event) => resolve(event.data), {
once: true,
});
});
}

promise_test(async (t) => {
iframe1.src =
new URL("resources/", self.location).pathname +
"show-picker-child-iframe.html";

// Wait for the iframe to report security errors when calling showPicker().
const securityErrors = await waitForSecurityErrors();
assert_equals(
securityErrors,
"",
"In same-origin iframes, showPicker() does not throw a SecurityError."
);
});

promise_test(async (t) => {
iframe2.src =
get_host_info().HTTP_NOTSAMESITE_ORIGIN +
new URL("resources/", self.location).pathname +
"show-picker-child-iframe.html";

// Wait for the iframe to report security errors when calling showPicker().
const securityErrors = await waitForSecurityErrors();
assert_equals(
securityErrors,
"select",
"In cross-origin iframes, showPicker() throws a SecurityError."
);
});

promise_test(async (t) => {
iframe3.src =
new URL("resources/", self.location).pathname +
"show-picker-child-iframe.html?documentDomain=" + get_host_info().ORIGINAL_HOST;

// Wait for the iframe to report security errors when calling showPicker().
const securityErrors = await waitForSecurityErrors();
assert_equals(
securityErrors,
"",
"In same-origin but cross-origin-domain iframes, showPicker() does not throw a SecurityError."
);
});

promise_test(async (t) => {
document.domain = get_host_info().ORIGINAL_HOST;
iframe4.src =
get_host_info().HTTP_REMOTE_ORIGIN +
new URL("resources/", self.location).pathname +
"show-picker-child-iframe.html?documentDomain=" + get_host_info().ORIGINAL_HOST;

// Wait for the iframe to report security errors when calling showPicker().
const securityErrors = await waitForSecurityErrors();
assert_equals(
securityErrors,
"select",
"In cross-origin but same-origin-domain iframes, showPicker() throws a SecurityError."
);
});
</script>
14 changes: 14 additions & 0 deletions html/semantics/forms/the-select-element/show-picker-disabled.tentative.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<!DOCTYPE html>
<title>Test showPicker() disabled requirement</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<select id="select" disabled>
<option>Item 1</option>
</select>
<script>
test(() => {
assert_throws_dom('InvalidStateError', () => { select.showPicker(); });
}, 'select showPicker() throws when disabled');
</script>
17 changes: 17 additions & 0 deletions html/semantics/forms/the-select-element/show-picker-multiple.tentative.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<!DOCTYPE html>
<title>Test showPicker() on multiple selects</title>
<meta name="timeout" content="long">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<select id="select" multiple>
<option>Item 1</option>
</select>
<script>
promise_test(async t => {
await test_driver.bless('show picker');
select.showPicker();
select.blur();
}, `select showPicker() does not throw when called on a <select multiple>`);
</script>
17 changes: 17 additions & 0 deletions html/semantics/forms/the-select-element/show-picker-size.tentative.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<!DOCTYPE html>
<title>Test showPicker() on sized selects</title>
<meta name="timeout" content="long">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<select id="select" size="4">
<option>Item 1</option>
</select>
<script>
promise_test(async t => {
await test_driver.bless('show picker');
select.showPicker();
select.blur();
}, `select showPicker() does not throw when called on a <select size="4">`);
</script>
23 changes: 23 additions & 0 deletions html/semantics/forms/the-select-element/show-picker-user-gesture.tentative.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<!DOCTYPE html>
<title>Test showPicker() user gesture requirement</title>
<meta name="timeout" content="long">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<body></body>
<script type=module>
test(() => {
const select = document.createElement("select");

assert_throws_dom('NotAllowedError', () => { select.showPicker(); });
}, `select showPicker() requires a user gesture`);

promise_test(async t => {
const select = document.createElement("select");

await test_driver.bless('show picker');
select.showPicker();
select.blur();
}, `select showPicker() does not throw when user activation is active`);
</script>