Add tests for notification inline reply idl properties #11122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrated existing html test to .any.js test + .idl interface to allow testing the new properties from a service worker scope. - See whatwg/notifications#132 for the spec change this tests. - See https://github.com/anitawoodruff/inline-notification-replies for an Explainer.
wpt-pr-bot
requested review from
chunywang,
ibelem,
jensl,
sideshowbarker,
xinliux and
yuki3
|
Note this PR adds two duplicate any.js tests as a workaround for #11105 - one can be deleted once that bug is fixed. |
|
@anitawoodruff, apologies for allowing this to sit unreviewed for so long. @lukebjerring and I have been working on getting the whole interfaces/ directory in sync with specs and auto-updating, and as part of that notifications.idl was updated in #11859. #11105 which you filed (thank you!) has now been resolved, and we have results from the .serviceworker. test here: That does reveal a problem which I've sent a fix for in #12500. Closing this PR, sorry for it being overtaken by other changes like this. |
wpt-pr-bot
requested review from
foolip and
lukebjerring
and removed request for
xinliux and
chunywang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated existing html test to .any.js test + .idl interface
to allow testing the new properties from a service worker scope.
See Add support for inline replies whatwg/notifications#132 for the
spec change this tests.
See https://github.com/anitawoodruff/inline-notification-replies
for an Explainer.