-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Reland] Handle appearance value changes during <select> showPicker.
When the appearance value changes as the result of the picker opening (e.g. via `::picker(select):open {appearance:auto}` or similar), we close the picker to avoid any oscillation or nonsensical behavior. This CL implements this change. The original CL [1] was reverted due to a strange bot failure [2] where the new set of promise_tests somehow fail because blink_wpt_tests is expecting an expectation file with a single blank line. I added a "Failure" expectation to hopefully avoid that, in Patchset 3. [1] https://chromium-review.googlesource.com/c/chromium/src/+/6094831 [2] https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/50289/overview Fixed: 376097114,370536090,367426156 Bug: 384394713 Change-Id: I2ab4e43db3de4b7125b564c366fe86bdf9f85cc4
- Loading branch information
1 parent
482f155
commit 2bfed68
Showing
1 changed file
with
13 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters