Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): z.objectUtil is not exist #8300

Closed
wants to merge 1 commit into from
Closed

fix(type): z.objectUtil is not exist #8300

wants to merge 1 commit into from

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Oct 31, 2024

Summary

closes #8277

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Release Packages:1.1.0-beta.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: neverland <[email protected]>

<!--
  Thank you for submitting a pull request!

  We appreciate the time and effort you have invested in making these changes. Please ensure that you provide enough information to allow others to review your pull request.

  Upon submission, your pull request will be automatically assigned with reviewers.

  If you want to learn more about contributing to this project, please visit: https://github.com/web-infra-dev/rspack/blob/main/CONTRIBUTING.md.
-->

## Summary

<!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? -->

<!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. -->

## Checklist

<!--- Check and mark with an "x" -->

- [ ] Tests updated (or not required).
- [ ] Documentation updated (or not required).
@SoonIter SoonIter enabled auto-merge (squash) October 31, 2024 11:52
@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Oct 31, 2024
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit f983b77
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67236f7f1828770008deddde

@SoonIter
Copy link
Member Author

😄 zod increses 3000 lines of core.api.md...

@SoonIter SoonIter requested a review from chenjiahan October 31, 2024 12:01
import { Chunk } from "../Chunk";
import type { Compilation, PathData } from "../Compilation";
import { Module } from "../Module";
import type * as t from "./types";

z.objectUtil;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some comments to explain this

@andersk
Copy link
Contributor

andersk commented Oct 31, 2024

auto-merge was automatically disabled November 1, 2024 02:26

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TypeScript errors TS2416 and TS2694 in @rspack/core
3 participants