Skip to content

Commit

Permalink
Revert feat(core): add yarn pnp support (#7639)
Browse files Browse the repository at this point in the history
  • Loading branch information
chenjiahan committed Jan 24, 2025
1 parent 23f7c8d commit 6a00eef
Show file tree
Hide file tree
Showing 49 changed files with 38 additions and 21,944 deletions.
3 changes: 2 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"**/CVS": true,
"**/.DS_Store": true,
"**/*.bk": true,
"/target": true
"/target": true,
"**/.yarn": true
},
"[typescript]": {
"editor.formatOnSave": true
Expand Down
160 changes: 4 additions & 156 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ quote = { version = "1.0.38" }
rayon = { version = "1.10.0" }
regex = { version = "1.11.1" }
ropey = "1.6.1"
rspack_resolver = { features = ["package_json_raw_json_api"], version = "0.5.0" }
rspack_resolver = { version = "0.3.6", features = ["package_json_raw_json_api"] }
rspack_sources = { version = "0.4.4" }
rustc-hash = { version = "2.1.0" }
serde = { version = "1.0.217" }
Expand Down Expand Up @@ -103,7 +103,6 @@ swc_html = { version = "=7.0.0" }
swc_html_minifier = { version = "=7.0.0", default-features = false }
swc_node_comments = { version = "=5.0.0" }

pnp = { version = "0.9.0" }

rspack_dojang = { version = "0.1.10" }

Expand Down
4 changes: 1 addition & 3 deletions crates/node_binding/binding.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ export declare class JsResolver {
}

export declare class JsResolverFactory {
constructor(pnp: boolean)
constructor()
get(type: string, options?: RawResolveOptionsWithDependencyType): JsResolver
}

Expand Down Expand Up @@ -1926,7 +1926,6 @@ export interface RawResolveOptions {
aliasFields?: Array<string>
restrictions?: Array<string>
roots?: Array<string>
pnp?: boolean
}

export interface RawResolveOptionsWithDependencyType {
Expand All @@ -1953,7 +1952,6 @@ export interface RawResolveOptionsWithDependencyType {
roots?: Array<string>
dependencyCategory?: string
resolveToContext?: boolean
pnp?: boolean
}

export interface RawResolveTsconfigOptions {
Expand Down
4 changes: 2 additions & 2 deletions crates/node_binding/src/resolver_factory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ pub struct JsResolverFactory {
#[napi]
impl JsResolverFactory {
#[napi(constructor)]
pub fn new(pnp: bool) -> napi::Result<Self> {
let input_filesystem = Arc::new(NativeFileSystem::new(pnp));
pub fn new() -> napi::Result<Self> {
let input_filesystem = Arc::new(NativeFileSystem {});
Ok(Self {
resolver_factory: None,
loader_resolver_factory: None,
Expand Down
Loading

0 comments on commit 6a00eef

Please sign in to comment.