Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open documentation in a Webview #271

Closed
wants to merge 4 commits into from
Closed

Conversation

kingdonb
Copy link
Collaborator

This is the internal docs branch

We will replace this link to the repository for vscode-gitops-tools with a reference to our "intro to gitops with VSCode extension" docs page, when we have one ready.

@kingdonb kingdonb force-pushed the open-webview-document branch from 5d8f386 to 8ab2711 Compare May 14, 2022 16:53
@kingdonb kingdonb force-pushed the open-webview-document branch 2 times, most recently from 8a760b1 to b54c6bf Compare May 27, 2022 17:54
@kingdonb kingdonb added this to the 0.20 milestone Jun 8, 2022
Kingdon Barrett added 2 commits July 1, 2022 10:58
The node-fetch package provides a fetch method which we can use to
retrieve some docs from a remote source, then display it in an editor
panel as webview.

Add a reference to the GitOps VSCode docs (content to-be-created)

Add a menu entry which triggers the webview for the docs on click, in
the docs tree view.

Signed-off-by: Kingdon Barrett <[email protected]>
Note this did not appear to be working

Signed-off-by: Kingdon Barrett <[email protected]>
@kingdonb kingdonb force-pushed the open-webview-document branch from b54c6bf to ec6305f Compare July 1, 2022 15:01
@kingdonb
Copy link
Collaborator Author

kingdonb commented Jul 1, 2022

This is the main feature planned for 0.20.0 – @juozasg has been working on some GIF documentation that we've been closing bugs to make sure that everything is perfect when we record.

If you are tracking the prerelease branch then you will find this feature as WIP, it's in the open-webview-document branch and I am triggering a build from that branch which has just been rebased now. 👍

The next step is to add the content from our document work that is outside of git

@kingdonb
Copy link
Collaborator Author

kingdonb commented Jul 1, 2022

is a pre-requisite of this IMHO.

We can load documentation from a webview, but in order to control formatting that webview should probably point somewhere other than a page on GitHub. When we are publishing a GitHub Page with each release, we can keep a versioned history or we can simply promote the latest version always. (I do not think we will try to provide versioned docs at least until after the pre-release or beta period is over.)

Kingdon Barrett and others added 2 commits July 1, 2022 11:27
@kingdonb
Copy link
Collaborator Author

This can close since it was replaced by #319 (it might be useful later, if someone needs to fetch from a URL, but the new feature uses tinytim.js as a templating/rendering engine in order to avoid any runtime dependency on the internet for now.)

@kingdonb kingdonb closed this Jul 14, 2022
@kingdonb kingdonb deleted the open-webview-document branch July 14, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants