parallel awaits for Sources in sourceDataProvider #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do as in workloadsDataProvider Signed-off-by: Kingdon Barrett <[email protected]>
|
This should (mostly) mitigate or close #267 |
This was referenced May 13, 2022
|
We can leave #267 open until it's clear the issue is really gone |
|
I am going to go ahead and merge this one to keep things moving, please review it when you get a chance. 👍 |
|
(This is a straggler and it was actually released in the already closed 0.19.x milestone) https://github.com/weaveworks/vscode-gitops-tools/releases/tag/0.19.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do as in workloadsDataProvider – when there are multiple resource kinds to fetch, get them in parallel
This avoids an uncomfortably long wait for
Sourcestree view timing out compared with the Workloads tree view that times out in about 30s.(Timeouts are not in our control for now, since the kubectl implementation comes from kubernetes provider extension, but we can control how many times we call operations in succession that might time out.)