fix: alert styling #1398
fix: alert styling #1398
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
📦 db
📦 app
📦 ui
automerge
WalkthroughThe changes involve downgrading several dependencies related to Prisma across multiple Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
JoeKarow
added
the
bugfix
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@prisma/[email protected]), npm/@prisma/[email protected]) |
#1329 Bundle Size — 3.49MiB (~+0.01%).f4328c7(current) vs e328a5e dev#1324(baseline) Warning Bundle contains 5 duplicate packages – View duplicate packages Bundle metrics
|
| Current #1329 |
Baseline #1324 |
|
|---|---|---|
 Initial JS |
3.06MiB(+0.01%) |
3.06MiB |
 Initial CSS |
9.54KiB |
9.54KiB |
 Cache Invalidation |
46.57% |
54.67% |
| Chunks |
67 |
67 |
| Assets |
80 |
80 |
| Modules |
2013 |
2013 |
| Duplicate Modules |
361 |
361 |
| Duplicate Code |
10.03% |
10.03% |
| Packages |
159 |
159 |
| Duplicate Packages |
5 |
5 |
Bundle size by type 1 change 1 regression
| Current #1329 |
Baseline #1324 |
|
|---|---|---|
| JS |
3.38MiB (~+0.01%) |
3.38MiB |
| Fonts |
94.54KiB |
94.54KiB |
| CSS |
9.54KiB |
9.54KiB |
| Other |
8.7KiB |
8.7KiB |
| IMG |
8.57KiB |
8.57KiB |
Bundle analysis report Branch JoeKarow/alert-formatting Project dashboard
Generated by RelativeCI Documentation Report issue
📦 Next.js Bundle Analysis for @weareinreach/appThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (6)
- apps/app/package.json (2 hunks)
- lambdas/cognito-user-migrate/package.json (2 hunks)
- packages/db/package.json (2 hunks)
- packages/db/prisma/data-migrations/2024-08-22_election-alert.ts (1 hunks)
- packages/db/prisma/data-migrations/index.ts (1 hunks)
- packages/ui/components/core/LocationBasedAlertBanner/index.tsx (4 hunks)
Files skipped from review due to trivial changes (3)
- apps/app/package.json
- lambdas/cognito-user-migrate/package.json
- packages/db/prisma/data-migrations/index.ts
Additional context used
Biome
packages/db/prisma/data-migrations/2024-08-22_election-alert.ts
[error] 22-22: The assignment should not be in an expression.
The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.(lint/suspicious/noAssignInExpressions)
Additional comments not posted (8)
packages/db/prisma/data-migrations/2024-08-22_election-alert.ts (3)
1-4: LGTM!The imports are appropriate and necessary for the functionality of the migration job.
The code changes are approved.
5-12: LGTM!The job metadata definition is clear and follows the expected structure.
The code changes are approved.
13-18: LGTM!The job export is well-structured and follows the expected format.
The code changes are approved.
packages/ui/components/core/LocationBasedAlertBanner/index.tsx (3)
1-19: LGTM!The imports and styles are appropriate and necessary for the functionality of the component. The styles are well-structured and follow the expected format.
The code changes are approved.
Line range hint
20-52: LGTM!The styles for
primaryandsecondaryare well-structured and follow the expected format. The use of theme variables and responsive design is appropriate.The code changes are approved.
Line range hint
53-107: LGTM!The
LocationBasedAlertBannercomponent is well-structured and follows the expected format. The use of early return statements and theStackcomponent improves readability and organization.The code changes are approved.
packages/db/package.json (2)
Line range hint
1-48: LGTM!The remaining dependencies and scripts are appropriate and necessary for the functionality of the package.
The code changes are approved.
Also applies to: 51-106, 108-151
49-50: Verify the reason for the downgrade and ensure no regressions.The dependencies for
@prisma/client,@prisma/instrumentation, andprismahave been downgraded from version5.19.0to5.18.0. Ensure that the downgrade aligns with the intended functionality and does not introduce regressions.Run the following script to verify the reason for the downgrade and ensure no regressions are introduced:
Also applies to: 107-107
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- packages/api/router/component/query.LocationBasedAlertBanner.handler.ts (1 hunks)
- packages/db/prisma/migrations/20240827192047_location_alert_order/migration.sql (1 hunks)
- packages/db/prisma/schema.prisma (1 hunks)
Additional comments not posted (3)
packages/db/prisma/migrations/20240827192047_location_alert_order/migration.sql (1)
1-3: LGTM!The SQL statement correctly adds a new column
orderto theLocationAlerttable with a default value of 0.The code changes are approved.
packages/api/router/component/query.LocationBasedAlertBanner.handler.ts (1)
27-27: LGTM! But verify the existence of theordercolumn in the database schema.The function is correctly implemented and the new
orderByproperty enhances the functionality. Ensure that theordercolumn exists in the database schema.The code changes are approved.
Run the following script to verify the existence of the
ordercolumn in the database schema:Verification successful
The
ordercolumn exists in the database schema.The search confirmed that the
ordercolumn is defined as anIntwith a default value of0in theschema.prismafile.
- Location:
packages/db/prisma/schema.prismaScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the `order` column in the `LocationAlert` table. # Test: Search for the `order` column in the Prisma schema. Expect: The `order` column should be present. rg --type prisma 'order\s+Int\s+@default\(0\)'Length of output: 79
Script:
#!/bin/bash # Description: Search for the `order` column definition in the entire codebase. # Test: Search for the `order` column as an `Int` with a default value of `0`. rg 'order\s+Int\s+@default\(0\)'Length of output: 107
packages/db/prisma/schema.prisma (1)
1425-1425: LGTM! But verify the usage of theorderfield in the codebase.The new field
orderis correctly added to the model. Ensure that the field is used consistently in the codebase.The code changes are approved.
Run the following script to verify the usage of the
orderfield in the codebase:
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
LocationBasedAlertBannercomponent for improved styling and layout.Bug Fixes
Documentation