Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add/link dropdowns #1076

Merged
merged 27 commits into from
Feb 12, 2024
Merged

feat: add/link dropdowns #1076

merged 27 commits into from
Feb 12, 2024

Conversation

JoeKarow
Copy link
Collaborator

@JoeKarow JoeKarow commented Feb 8, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: IN-944

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
inreach-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 8:05pm

@github-actions github-actions bot added 📦 ui 📦 env 📦 api automerge Enable Kodiak auto-merge kodiak: merge.method = 'squash' Kodiak will squash merge this PR. labels Feb 8, 2024
@JoeKarow JoeKarow added the new-feature New features or options. label Feb 8, 2024
@ghost
Copy link

ghost commented Feb 8, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

socket-security bot commented Feb 8, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@turf/[email protected] Transitive: eval +49 1.17 MB
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +145 33.1 MB

View full report↗︎

InReach-svc
InReach-svc previously approved these changes Feb 12, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/[email protected]
  • Install script: install
  • Source: node install/check

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link
Contributor

📦 Next.js Bundle Analysis for @weareinreach/app

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (575 KB)
/ 279.3 KB 678.82 KB 118.06% (🟡 +0.20%)
/org/[slug] 315.38 KB 714.89 KB 124.33% (🟡 +2.79%)
/org/[slug]/[orgLocationId] 309.88 KB 709.39 KB 123.37% (🟡 +2.79%)
/org/[slug]/[orgLocationId]/edit 311.04 KB 710.56 KB 123.58% (🟡 +2.78%)
/org/[slug]/[orgLocationId]/edit/[orgServiceId] 269.25 KB 668.77 KB 116.31% (🟡 +0.21%)
/org/[slug]/edit 274.8 KB 674.32 KB 117.27% (🟡 +0.21%)
/org/[slug]/remote 268.69 KB 668.21 KB 116.21% (🟡 +0.21%)
/search/[...params] 271.1 KB 670.62 KB 116.63% (🟡 +0.21%)
/search/intl/[country] 270.13 KB 669.65 KB 116.46% (🟡 +0.21%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

🤖 No test run has been triggered as your Meticulous project has been deactivated (since you haven't viewed any test results in a while). Click here to reactivate.

Last updated for commit 3445ea6. This comment will update as new commits are pushed.

@JoeKarow JoeKarow requested a review from InReach-svc February 12, 2024 20:06
@kodiakhq kodiakhq bot merged commit 708456b into dev Feb 12, 2024
27 of 30 checks passed
@kodiakhq kodiakhq bot deleted the IN-944-edit-location-page-dropdown branch February 12, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants