Update README #217
Merged
Update README #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsens
reviewed
Mar 5, 2024
philipsens
reviewed
Mar 5, 2024
philipsens
requested changes
Mar 5, 2024
mhdirkse
reviewed
Mar 5, 2024
| @@ -240,12 +240,8 @@ Create and publish NPM package and WebJar | |||
| - In the terminal run the following command `npm login`, which prompts you to log into NPM. | |||
|
|
|||
| ### Creating and publishing an NPM package | |||
| - Run the command `yarn install --frozen-lockfile`, to sync with changes done by others | |||
| - Run the command `yarn install --immutable`, to sync with changes done by others | |||
| - Run the command `ng build`, to build the current project | |||
There was a problem hiding this comment.
I have to do yarn ng build instead of just ng build.
There was a problem hiding this comment.
That means your angular cli is not installed properly, this still works for anyone that has it installed correctly.
This is also something that was not changed in this pr.
mhdirkse
reviewed
Mar 5, 2024
README.md
Outdated
| - Copy the following files into the generated `dist/ladybug` folder | ||
| - README.md | ||
| - LICENSE | ||
| - package.json | ||
| - In the `dist/ladybug/index.html` change the types of the three scripts on line 15 to `application/javascript` (so `type="module"` -> `type="application/javascript"`). The specific scripts are: |
There was a problem hiding this comment.
On my computer it turned out to be line 14.
mhdirkse
previously requested changes
Mar 5, 2024
This is not the case for every user, it depends on if you have 2FA enabled. |
philipsens
approved these changes
Mar 6, 2024
MatthijsSmets
dismissed
mhdirkse’s stale review
Suggested changes are not required
jacodg
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular.json was updated in ladybug-frontend which requires an update to the README.md