fix readonly does not work for 'Teeny Rich textarea'

[sapayth]

fixes #482

Issue:
Textarea > Read only does not work for 'Teeny Rich textarea' as field is still editable

Scenario:
New Post Form > Add Textarea > Edit Advanced > Select 'Teeny Rich textarea' > Also select "Read only" option > Save > Field is still editable

Summary by CodeRabbit

• New Features
  • Introduced a read-only state for the textarea, enhancing user interaction control.
• Improvements
  • Enhanced logic for rendering the rich text editor with improved type safety.
  • Updated validation for rich text editor settings to ensure accurate configuration.

[coderabbitai]

Walkthrough

The changes enhance the render method of the Form_Field_Textarea class by improving the logic for rendering a rich text editor and handling the read-only state. The condition checks for the required and rich fields are updated to use strict comparisons, ensuring type safety. A new feature allows the textarea to be read-only, modifying the tinymce_settings array accordingly. These modifications aim to improve the functionality and robustness of the textarea rendering process.

Changes

File	Change Summary
includes/Fields/Form_Field_Textarea.php	Updated logic for rendering rich text editor and read-only state. Improved strict comparisons for required and rich fields. Added handling for a read-only state in the tinymce_settings.

Suggested labels

QA Approved, Ready to Merge

🐇 In the meadow where bunnies play,
A textarea shines bright today.
With strict checks and read-only grace,
User input finds a safe space.
Hooray for changes, let’s all cheer,
A better editor is finally here! 🌼

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c2ef2ab and 2daaee9.

Files selected for processing (1)

• includes/Fields/Form_Field_Textarea.php (3 hunks)

Additional comments not posted (4)

includes/Fields/Form_Field_Textarea.php (4)

36-36: LGTM!

The change from a loose comparison (==) to a strict comparison (===) improves type safety when checking the required field setting. The change is correct.

---

41-43: LGTM!

The use of strict comparison in in_array() ensures that only exact matches of 'yes' or 'teeny' are considered valid for the rich field setting. This improves the accuracy of the condition. The change is correct.

---

61-63: LGTM!

The change introduces a new feature to handle the read-only state for the textarea. When the read_only field setting is not empty, the readonly key in the $tinymce_settings array is set to true. This will make the rich text editor read-only, providing the desired functionality. The change is correct.

---

74-74: LGTM!

The addition of an empty line after the $editor_settings variable assignment improves code readability. It's a minor formatting change with no functional impact. The change is acceptable.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.