Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: update dynamic properties use #1457

Conversation

sapayth
Copy link
Member

@sapayth sapayth commented May 20, 2024

The creation of dynamic properties is deprecated from PHP 8.x.x. fixed in this PR

Summary by CodeRabbit

  • Bug Fixes

    • Resolved issues with dynamic properties by ensuring the #[AllowDynamicProperties] attribute works correctly across various components of the application.
  • Code Quality

    • Improved code consistency by updating string construction methods in the wpuf_payment_success_page function.

Copy link

coderabbitai bot commented May 20, 2024

Walkthrough

The recent updates primarily focus on ensuring the correct functionality of the #[AllowDynamicProperties] attribute across various files by adding fully-qualified import statements for AllowDynamicProperties. Additionally, a minor change in string construction within the wpuf_payment_success_page function was made to use concatenation instead of interpolation.

Changes

Files/Paths Change Summary
Lib/invisible_recaptcha.php Added use \AllowDynamicProperties; for fully-qualified import.
admin/class-admin-settings.php Added use \AllowDynamicProperties; for fully-qualified import.
includes/Admin.php Added use \AllowDynamicProperties; in WeDevs\Wpuf namespace.
includes/.../Admin_Form.php Added use \AllowDynamicProperties; in WeDevs\Wpuf\Admin\Forms namespace.
includes/.../Form.php Added fully-qualified AllowDynamicProperties import in WeDevs\Wpuf\Admin\Forms namespace.
includes/.../Pro_Form_Preview_EDD.php Added use \AllowDynamicProperties; in WeDevs\Wpuf\Admin\Forms\Post\Templates namespace.
includes/.../Frontend_Form_Ajax.php Added use \AllowDynamicProperties; in WeDevs\Wpuf\Ajax namespace.
includes/.../Form_Field_Post_Taxonomy.php Added fully-qualified import for AllowDynamicProperties.
includes/Frontend.php Added use \AllowDynamicProperties; in WeDevs\Wpuf namespace.
wpuf.php Added fully-qualified import for AllowDynamicProperties.
wpuf-functions.php Changed string interpolation to concatenation for $success_query in wpuf_payment_success_page function.

🐇✨ In code we trust, with imports just right,
Ensuring our attributes shine so bright.
With dots for strings and namespaces clear,
Our functions run smooth, no bugs to fear.
Hopping through files, making things neat,
A rabbit's touch makes the code complete! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between b7474d7 and 35f1334.
Files selected for processing (11)
  • Lib/invisible_recaptcha.php (1 hunks)
  • admin/class-admin-settings.php (1 hunks)
  • includes/Admin.php (1 hunks)
  • includes/Admin/Forms/Admin_Form.php (1 hunks)
  • includes/Admin/Forms/Form.php (1 hunks)
  • includes/Admin/Forms/Post/Templates/Pro_Form_Preview_EDD.php (1 hunks)
  • includes/Ajax/Frontend_Form_Ajax.php (1 hunks)
  • includes/Fields/Form_Field_Post_Taxonomy.php (1 hunks)
  • includes/Frontend.php (1 hunks)
  • wpuf-functions.php (1 hunks)
  • wpuf.php (1 hunks)
Files skipped from review due to trivial changes (4)
  • Lib/invisible_recaptcha.php
  • admin/class-admin-settings.php
  • includes/Admin/Forms/Form.php
  • wpuf-functions.php
Additional comments not posted (12)
includes/Admin/Forms/Post/Templates/Pro_Form_Preview_EDD.php (2)

6-6: Correct use of fully-qualified namespace for AllowDynamicProperties.


5-5: Good documentation on the necessity of the fully-qualified namespace for the attribute to function.

includes/Admin.php (2)

6-6: Correct use of fully-qualified namespace for AllowDynamicProperties.


5-5: Good documentation on the necessity of the fully-qualified namespace for the attribute to function.

includes/Frontend.php (2)

6-6: Correct use of fully-qualified namespace for AllowDynamicProperties.


5-5: Good documentation on the necessity of the fully-qualified namespace for the attribute to function.

wpuf.php (2)

39-39: Correct use of fully-qualified namespace for AllowDynamicProperties.


38-38: Good documentation on the necessity of the fully-qualified namespace for the attribute to function.

includes/Admin/Forms/Admin_Form.php (2)

6-6: Correct use of fully-qualified namespace for AllowDynamicProperties.


5-5: Good documentation on the necessity of the fully-qualified namespace for the attribute to function.

includes/Fields/Form_Field_Post_Taxonomy.php (1)

11-12: The use of AllowDynamicProperties is correctly implemented to address PHP 8.x deprecations concerning dynamic properties.

includes/Ajax/Frontend_Form_Ajax.php (1)

6-6: The use of AllowDynamicProperties is correctly implemented to address PHP 8.x deprecations concerning dynamic properties.

@Rubaiyat-E-Mohammad Rubaiyat-E-Mohammad added QA In Progress QA Approved This PR is approved by the QA team Ready to Merge This PR is now ready to be merged and removed needs: testing QA In Progress labels Jun 4, 2024
@sapayth sapayth merged commit ac1a751 into weDevsOfficial:develop Jul 2, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Approved This PR is approved by the QA team Ready to Merge This PR is now ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants