-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: update dynamic properties use #1457
enhance: update dynamic properties use #1457
Conversation
WalkthroughThe recent updates primarily focus on ensuring the correct functionality of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (11)
- Lib/invisible_recaptcha.php (1 hunks)
- admin/class-admin-settings.php (1 hunks)
- includes/Admin.php (1 hunks)
- includes/Admin/Forms/Admin_Form.php (1 hunks)
- includes/Admin/Forms/Form.php (1 hunks)
- includes/Admin/Forms/Post/Templates/Pro_Form_Preview_EDD.php (1 hunks)
- includes/Ajax/Frontend_Form_Ajax.php (1 hunks)
- includes/Fields/Form_Field_Post_Taxonomy.php (1 hunks)
- includes/Frontend.php (1 hunks)
- wpuf-functions.php (1 hunks)
- wpuf.php (1 hunks)
Files skipped from review due to trivial changes (4)
- Lib/invisible_recaptcha.php
- admin/class-admin-settings.php
- includes/Admin/Forms/Form.php
- wpuf-functions.php
Additional comments not posted (12)
includes/Admin/Forms/Post/Templates/Pro_Form_Preview_EDD.php (2)
6-6
: Correct use of fully-qualified namespace forAllowDynamicProperties
.
5-5
: Good documentation on the necessity of the fully-qualified namespace for the attribute to function.includes/Admin.php (2)
6-6
: Correct use of fully-qualified namespace forAllowDynamicProperties
.
5-5
: Good documentation on the necessity of the fully-qualified namespace for the attribute to function.includes/Frontend.php (2)
6-6
: Correct use of fully-qualified namespace forAllowDynamicProperties
.
5-5
: Good documentation on the necessity of the fully-qualified namespace for the attribute to function.wpuf.php (2)
39-39
: Correct use of fully-qualified namespace forAllowDynamicProperties
.
38-38
: Good documentation on the necessity of the fully-qualified namespace for the attribute to function.includes/Admin/Forms/Admin_Form.php (2)
6-6
: Correct use of fully-qualified namespace forAllowDynamicProperties
.
5-5
: Good documentation on the necessity of the fully-qualified namespace for the attribute to function.includes/Fields/Form_Field_Post_Taxonomy.php (1)
11-12
: The use ofAllowDynamicProperties
is correctly implemented to address PHP 8.x deprecations concerning dynamic properties.includes/Ajax/Frontend_Form_Ajax.php (1)
6-6
: The use ofAllowDynamicProperties
is correctly implemented to address PHP 8.x deprecations concerning dynamic properties.
The creation of dynamic properties is deprecated from PHP 8.x.x. fixed in this PR
Summary by CodeRabbit
Bug Fixes
#[AllowDynamicProperties]
attribute works correctly across various components of the application.Code Quality
wpuf_payment_success_page
function.