check assignee on task

[iftakharul-islam]

Added empty assignee check

Summary by CodeRabbit

• Bug Fixes
  • Improved input validation for task assignees in task creation and update methods
  • Enhanced error handling for assignee parameter processing

[coderabbitai]

Walkthrough

The pull request introduces a modification to the Task_Controller class in the task management system. The changes focus on improving the handling of the assignees parameter in two methods: store and task_update. The primary enhancement is the addition of a robust input validation mechanism that ensures the assignees parameter is always processed as an array, preventing potential errors from unexpected input types.

Changes

File	Change Summary
src/Task/Controllers/Task_Controller.php	Updated store and task_update methods to safely handle assignees parameter by adding type checking and defaulting to an empty array

Poem

🐰 A rabbit's tale of code so neat,
Where assignees dance to a safer beat
Input checked with careful grace
No more errors in this coding space
Robust and clean, our controller sings! 🔧

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Task/Controllers/Task_Controller.php (1)

167-169: Improve input validation and error handling for assignees.

The change correctly handles non-array input and ensures type safety. However, consider these improvements:

1. Add input validation to reject invalid assignee values
2. Log warnings when invalid input is received
3. Document the expected input format

Apply this diff to enhance the validation:

-        $assignees     = is_array($request->get_param('assignees')) ? 
-        array_map('intval', $request->get_param('assignees')) : [];
-
+        $raw_assignees = $request->get_param('assignees');
+        $assignees = [];
+        
+        if (is_array($raw_assignees)) {
+            foreach ($raw_assignees as $assignee) {
+                $assignee_id = intval($assignee);
+                if ($assignee_id > 0) {
+                    $assignees[] = $assignee_id;
+                } else {
+                    error_log(sprintf(
+                        'Invalid assignee value "%s" provided in task creation',
+                        esc_html($assignee)
+                    ));
+                }
+            }
+        } else {
+            error_log(sprintf(
+                'Invalid assignees format provided in task creation. Expected array, got %s',
+                gettype($raw_assignees)
+            ));
+        }

Consider adding PHPDoc to document the expected format:

/**
 * Store a new task.
 *
 * @param WP_REST_Request $request Request object
 * @return WP_REST_Response
 *
 * @throws WP_Error
 *
 * Expected format for assignees parameter:
 * array<int> List of user IDs to assign to the task
 * Example: [1, 2, 3]
 */

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 801c182 and 975cf0c.

📒 Files selected for processing (1)

• src/Task/Controllers/Task_Controller.php (1 hunks)