Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raul Gutierrez Homework Pull #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Raul Gutierrez Homework Pull #19

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3adc0bf
update css file
rcgutierrez Sep 14, 2017
935311e
style update
rcgutierrez Sep 14, 2017
da503a3
<p> first letter update
rcgutierrez Sep 14, 2017
38d3a60
final style update
rcgutierrez Sep 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 113 additions & 0 deletions starter-code/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
body{
font-family: Lato, sans-serif;
padding-left: 30px;
margin-left: 20px;
border-left-style: solid;
border-left-color: rgba(195,195,195,.8);

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically when you are specifying border CSS, you want to set the width, style, and color. You can do that in one line: border-left: 10px solid rgba(195, 195, 195, .8);

}

header{
padding-top: 40px;
}

a{
text-decoration: none;
all: unset;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than using this CSS property, you will want to consider a normalize or reset css sheet instead.


}

nav a{
margin: 0 8px;
text-decoration: underline;
color: rgba(195,195,195,.8);
font-size: 18px;
}

h1{
all: unset;
text-decoration: none;
color: rgba(255, 200, 66,.6);
font-size: 50px;
font-weight: 100;
}

h2{
font-weight: 300;
font-size: 30px;

}

article h2{
margin-top: 5px;
}

h2 a{
font-weight: 300;
font-size: 35px;
margin-top: 0;
}

h3 {
font-size: 30px;
font-weight:100;
margin-bottom: 0;
color: rgba(195,195,195,.8);
}

h4{
text-align: right;
}

article p::first-letter{
font-size: 450%;
display: block;
float: left;
color: rgba(195,195,195,.8);
line-height: 80%;
margin: 5px;
}

p{
color: rgba(0,0,0,.6)
}

h4 a{
color: rgba(255, 200, 66,.6);
text-align: right;
}

img{
width: 80%;
align: center;
}

article{
border-bottom-style: solid;
border-bottom-width: thin;
border-bottom-color: rgba(195,195,195,.8);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combine these into one line: border-bottom: thin solid rgba(195,195,195,0.8);

width: 80%;
}

footer{
margin-top: 55px;
}

footer a{
text-decoration: none;
color: rgba(255, 200, 66,.6);
margin: 0;
}

footer nav{
color: rgba(195,195,195,.8);
}

footer p{
color: rgba(195,195,195,.8);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This color value is being set multiple times throughout the css file.. it would make more sense to set the entire body color to this once, or move selectors together to set the color at once. Whenever you start writing out the same property and value more than once, it's a good idea to think how you can adjust selectors to reduce that repetition.

}

a:hover{
transition: 1.5s;
color: black;
}