Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rika CSS HWmy #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rika CSS HWmy #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions starter-code/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
*{
margin: 10px;
font-family: Lato;
text-align: left;

}

header {

}

h1 a, h4 a {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great selector choice here!!

color: rgb(238, 226, 122);

}
h1 a {
font-size: 50px;
font-weight: 300;
text-decoration: none;

}

h2 {
font-weight: 200;
}

nav a {
color: rgb(208, 207, 202);
font-size: 20px;
}

article {
max-width: 600%;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you might be a bit confused on when to use %. Setting a max-width of 600% means that this article will be 6times as large as the full page or window. I'm pretty sure that's not what you meant to do here. Did you perhaps mean 60% so it only takes up a little over half the window?

padding: 50px;
border-bottom: solid 2px rgb(231, 231, 226);;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch your typing - you have two ;; at the end of this line which could break the file.


}
h4 a {
float: right;
}

h2 a{
font-weight: lighter;
text-decoration: none;
font-size: 30px;
color: #292928;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be consistent in your color values. If you want to use hex codes, use them all the time, otherwise stick with rgb.


}

h3 {
color: rgb(231, 231, 226);
font-size: 40px;
font-weight: lighter;

}

img {
max-width: 700%;
}
p{
padding-right: 30px;
}

span {
float: left;
width: 0.7em;
font-size: 400%;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is another area where I don't think you meant to use %. Font-sizes should usually be set in px, rem, or em.

line-height: 50%;
color: rgb(231, 231, 226);
}


}

footer {

}