[WAZO-4003] Allow extend api client #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bogue
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
wazo-js-sdkis very useful for end-user's applications type. But when building an admin application for example, we do not include all admin APIs. So developers needs to use two set of codebase to handle this use case.We have API Requesters, but this also force developers to loop to each API Requester and initialiser to handle
refreshTokenCallbackmecanism.Summary of changes
BaseApiClientclassWazoApiClientnow depends on BaseApiClientgetApiClientnow accept new parameter for custom ApiClient