-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a wsh launch command #1947
Conversation
This creates a new command `wsh launch` that will launch a widget that has been defined in the widgets.json file.
WalkthroughThe pull request introduces a new command, ✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
cmd/wsh/cmd/wshcmd-launch.go (2)
36-40
: Consider increasing the timeout for configuration retrieval.A 2000ms timeout might be too short for large configurations, especially in high-latency environments or when dealing with extensive widget definitions.
- config, err := wshclient.GetFullConfigCommand(RpcClient, &wshrpc.RpcOpts{Timeout: 2000}) + config, err := wshclient.GetFullConfigCommand(RpcClient, &wshrpc.RpcOpts{Timeout: 5000})
51-64
: Enhance the output message for better user feedback.While the current output is functional, it could be more descriptive to help users understand the widget's state.
- WriteStdout("launched widget %q: %s\n", widgetId, oref) + magnifiedStr := "" + if createBlockData.Magnified { + magnifiedStr = " (magnified)" + } + WriteStdout("launched widget %q%s: %s\n", widgetId, magnifiedStr, oref)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
cmd/wsh/cmd/wshcmd-launch.go
(1 hunks)docs/docs/wsh-reference.mdx
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (go)
- GitHub Check: Build for TestDriver.ai
🔇 Additional comments (3)
cmd/wsh/cmd/wshcmd-launch.go (2)
14-27
: LGTM! Command structure follows best practices.The command definition and initialization follow standard cobra patterns with proper argument validation and flag registration.
42-49
: LGTM! Widget lookup logic is robust.The implementation correctly checks both user-defined and default widgets, with clear error messaging.
docs/docs/wsh-reference.mdx (1)
671-700
: LGTM! Documentation is comprehensive and accurate.The documentation clearly explains the command's functionality, flags, and usage patterns, with helpful examples and tips.
This creates a new command
wsh launch
that will launch a widget that has been defined in the widgets.json file.