NODE-2622 Delete old data #3912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- setIncreaseParallelism & setMaxBackgroundJobs: 4 -> 5.
This reverts commit 2697ae1.
- default parallelism; - fixed tests.
| val updateAtKeys = new ArrayBuffer[Key[BalanceNode]]() | ||
|
|
||
| val changedKeyPrefix = KeyTags.ChangedWavesBalances.prefixBytes | ||
| val changedFromKey = Keys.changedWavesBalances(fromInclusive) // Doesn't matter, we need this only to parse |
There was a problem hiding this comment.
what does this comment mean?
changedFromKey is used not only for parsing but also in iterateOverWithSeek as "seek" parameter
There was a problem hiding this comment.
It means, fromInclusive doesn't affect the parsing result. Changed the comment to make it clear.
xrtm000
reviewed
Jan 12, 2024
| import java.util | ||
| import java.util.concurrent.{AbstractExecutorService, TimeUnit} | ||
|
|
||
| object RunNowExecutorService extends AbstractExecutorService { |
There was a problem hiding this comment.
Is this not the same as MoreExecutors.newDirectExecutorService()?
- maxWriteBufferNumber in default CF: 2 -> 3.
- maxWriteBufferNumber in default CF: 3 -> 4.
- setIncreaseParallelism: 4 -> 8; - maxBackgroundJobs removed.
- setMaxSubcompactions removed.
…ould be calculated)
- setIncreaseParallelism: 6 -> 7.
ivan-mashonskiy
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new functionality for deletion of old data. It doesn't affect the main functionality of NODE.
Enabling this funcitonality starts a background cleanup and affects:
GET /addresses/balance/$addr/$confirmations- confirmations should be <= 1000 to get a guaranteed result.GET /addresses/balancePOST /addresses/balanceGET /assets/$asset/distribution/$height/limit/$limitGET /debug/balances/history/$addrGET /debug/stateWaves/$heightA- WAVES balance history for addressAA- Asset balance history for addressChanges:
waves.db.cleanup-interval. See more information in the config;Datakeys containAddressIdinstead ofPublicKeyHash;Score,BlockTransactionsFee,BlockReward,WavesAmount,HitSource,BloomFilterChecksum;ChangedWavesBalancesandLastCleanupHeightto support the new functionality;Exporternow is stack-safe;Explorercompatibility with version-1.5.x and recent changes;node-ittests;