Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move lang out of ngRedux store, add GoogleMaterialModule #398

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

robstoll
Copy link
Contributor

moreover:

  • add language-selector.component for the language dropdown (as
    replacement of state-selector which no longer works for lang)
  • distinguish between lang and selector in translation json files

@robstoll robstoll requested a review from fabianpage July 23, 2021 21:10
@robstoll
Copy link
Contributor Author

robstoll commented Jul 23, 2021

Fixes #399

@robstoll
Copy link
Contributor Author

PR not yet good to merge, inadvertently changed the following:
before:
image
Now with this PR
image

moreover:
- add language-selector.component for the language dropdown (as
  replacement of state-selector which no longer works for lang)
- distinguish between lang and selector in translation json files
@fabianpage fabianpage force-pushed the refactor-architecture branch from 2012b11 to 21a3503 Compare July 28, 2021 08:27
@fabianpage fabianpage merged commit 3847cf5 into water-fountains:develop Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detail component does not react to language change regarding onImageChange
2 participants