Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detail component does not react to language change regarding onImageChange #399

Closed
robstoll opened this issue Jul 23, 2021 · 0 comments · Fixed by #398
Closed

Detail component does not react to language change regarding onImageChange #399

robstoll opened this issue Jul 23, 2021 · 0 comments · Fixed by #398
Labels
Bug https://github.com/dotnet/roslyn/wiki/Labels-used-for-issues#bugs

Comments

@robstoll
Copy link
Contributor

Describe the bug
The current language is taken when the component is loaded. If one changes the language afterwards, then this change is not reflected in onImageChange which inter alia sets the caption (of the image I guess)

To Reproduce
Steps to reproduce the behavior:

  1. click on a fountain
  2. open up the developer console (F12)
  3. change the language => there is no console output regarding onImageChange

Expected behavior
detail component should subscribe to language changes
@robstoll robstoll added the Bug https://github.com/dotnet/roslyn/wiki/Labels-used-for-issues#bugs label Jul 23, 2021
@robstoll robstoll mentioned this issue Jul 23, 2021
Merged
@robstoll robstoll linked a pull request Jul 23, 2021 that will close this issue
move lang out of ngRedux store, add GoogleMaterialModule #398
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug https://github.com/dotnet/roslyn/wiki/Labels-used-for-issues#bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move lang out of ngRedux store, add GoogleMaterialModule tegonal/proximap
1 participant
@robstoll