Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide possibility to load fountains for given bounds #148

Open
robstoll opened this issue Dec 17, 2021 · 0 comments
Open

provide possibility to load fountains for given bounds #148

robstoll opened this issue Dec 17, 2021 · 0 comments

Comments

@robstoll
Copy link
Contributor

No description provided.

@robstoll robstoll self-assigned this Dec 17, 2021
@robstoll robstoll added this to Board Dec 17, 2021
@robstoll robstoll moved this to Todo in Board Dec 17, 2021
@robstoll robstoll mentioned this issue Dec 17, 2021
Open
@robstoll robstoll removed the status in Board Dec 17, 2021
@robstoll robstoll removed their assignment Dec 17, 2021
@robstoll robstoll removed this from Board Dec 17, 2021
@robstoll robstoll moved this to In Progress in Board Dec 20, 2021
@robstoll robstoll added this to Board Dec 20, 2021
robstoll added a commit to tegonal/datablue that referenced this issue Dec 22, 2021
@robstoll
water-fountains#148 fetch by bounds instead of city
aa6848b 
the /fountains endpoint now requires sw and ne query parameter instead of city

moreover:
- require a location for byId so that we can look it up in cache
- fix TestCityBounds (water-fountains#157)
- failure handling for cache populati
- send 404 in case json object is undefined (and not only log error
  and send undefined)
- catch errors and send to next middleware (water-fountains#155)
- removed database.service.ts
- increased REQUEST_LIMIT to 10MB as we query more fountains now
- updated Api.yaml accordingly
- updated express from 4.17.1 to 4.17.2
- update node-cache from 4.2.1 to 5.1.2

cleanup:
- use BoundingBox instead of separate minLng, minLat... as parameter
- added last_scan to FountainCollection and provide a factory function
  which set it automatically to new Date()
- fix binding in router.ts
robstoll added a commit to tegonal/datablue that referenced this issue Dec 22, 2021
@robstoll
water-fountains#148 fetch processing errors by bound
8838101
robstoll added a commit to tegonal/datablue that referenced this issue Dec 22, 2021
@robstoll
water-fountains#148 use oldest lastScan for aggregation
bed2f86 
also, re-added the fill-artist etc. logic for byId
robstoll added a commit to tegonal/datablue that referenced this issue Dec 22, 2021
@robstoll
water-fountains#148 use oldest lastScan for aggregation
3ff2fdb 
also, re-added the fill-artist etc. logic for byId
robstoll added a commit that referenced this issue Dec 22, 2021
@robstoll
Merge pull request #160 from tegonal/#148-load-by-bound
d55010b 
#148 load by bound
@robstoll robstoll moved this from In Progress to Verify in Board Dec 22, 2021
robstoll added a commit that referenced this issue Dec 22, 2021
@robstoll
Merge pull request #161 from tegonal/#148-load-by-bound
e7035d2 
fix minux lng/lat bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Board
Status: Verify
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robstoll