Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load fountains outside of pre-defined cities #491

Open
robstoll opened this issue Dec 17, 2021 · 0 comments
Open

load fountains outside of pre-defined cities #491

robstoll opened this issue Dec 17, 2021 · 0 comments
Assignees
@robstoll

Comments

@robstoll
Copy link
Contributor

requires: water-fountains/datablue#148

  • allow that a user can move out of a city and fountains are still loaded for that area
  • make the corresponding url shareable by introducing a loc query param with format lat,lng,zoom where zoom is ${zoomLevel}z
@robstoll robstoll added this to Board Dec 17, 2021
@robstoll robstoll self-assigned this Dec 17, 2021
@robstoll robstoll moved this to In Progress in Board Dec 17, 2021
robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#491 loc / water-fountains#493 map.resize / water-foun…
18f2762 
…tains#489 switch between cities

moreover:
- water-fountains#490 do not handle programmatic route changes
- fix some null vs. undefined issues
- update mapboxgl to latest version

not included yet in this commit:
- loading fountains outside of a city
robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#491 loc / water-fountains#493 map.resize / water-foun…
039d94c 
…tains#489 switch between cities

moreover:
- water-fountains#490 do not handle programmatic route changes
- fix some null vs. undefined issues
- update mapboxgl to latest version

not included yet in this commit:
- loading fountains outside of a city
robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#491 loc / water-fountains#493 map.resize / water-foun…
1724149 
…tains#489 switch between cities

moreover:
- water-fountains#490 do not handle programmatic route changes
- fix some null vs. undefined issues
- update mapboxgl to latest version

not included yet in this commit:
- loading fountains outside of a city
robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#491 loc / water-fountains#493 map.resize / water-foun…
64fe564 
…tains#489 switch between cities

moreover:
- water-fountains#490 do not handle programmatic route changes
- fix some null vs. undefined issues
- update mapboxgl to latest version

not included yet in this commit:
- loading fountains outside of a city
robstoll added a commit that referenced this issue Dec 17, 2021
@robstoll
Merge pull request #494 from tegonal/shared-location
b3315db 
#491 loc / #493 map.resize / #489 switch between cities
robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#491 use map.center for loc as jumpTo requires it
b75569c 
moreover:
- also use the first load strategy for ?loc= (move into inner
  actOnFirstLoad function)
- don't navigate in router.component.ts if neither the city nor the
  query params have changed
robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#491 use map.center for loc as jumpTo requires it
9af8dc8 
moreover:
- also use the first load strategy for ?loc= (move into inner
  actOnFirstLoad function)
- don't navigate in router.component.ts if neither the city nor the
  query params have changed
robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#491 use map.center for loc as jumpTo requires it
c7bf8d2 
moreover:
- also use the first load strategy for ?loc= (move into inner
  actOnFirstLoad function)
- don't navigate in router.component.ts if neither the city nor the
  query params have changed
robstoll added a commit that referenced this issue Dec 17, 2021
@robstoll
Merge pull request #498 from tegonal/shared-location
7722b64 
#491 use map.center for loc as jumpTo requires it
robstoll added a commit that referenced this issue Dec 22, 2021
@robstoll
Merge pull request #507 from tegonal/#491-load-by-bounds
b3cf3c3 
#419 load by bounding box
@robstoll robstoll moved this from In Progress to Verify in Board Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robstoll robstoll

Labels
None yet
Projects
Board
Status: Verify
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robstoll