feat(nats): flag to change persistence of streams

[markkovari]

Feature or Problem

cli toggle to modify the nats stream persistence between file and memory.

I do seek some guidance regarding testing here. Since we have multiple tests which have the file - default - mode enabled, should I create another suite or how do you think should I add tests for this?

Thank you

Related Issues

#479

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

[ahmedtadde]

hey @markkovari thank you for this submission! Upon a first look, I only found a spelling issue that needs to be addressed. Otherwise, the changes made should do the trick.

testing wise, I believe we probably want the following

• ensure all the existing tests work as expected (no regression bugs)... this is basically just running the test suite locally
• ensure that the flag (parsing) works... as in, when not specified -> expected default value & when specified -> maps to expected values (File, Memory). This may be pedantic though; but a good exercise for a first issue PR. it is up to you.
• for Memory mode, ensure that there is a file when using File mode and the absence of said file otherwise. This entails figuring out how to find/peek/inspect a JetStream persistence file for a given stream.

[markkovari]

@ahmedtadde thanks for the elaborate answer, will look into it between two food coma and how the tests are outlined.

[brooksmtownsend]

Quick request to un-hide the flag, other piece optional but I'm thinking it'll be more clear to have lowercase flag options

[brooksmtownsend]

@markkovari this looks good! If there's any test to run, I think there's just two that we can do:

1. Change one of the e2e tests to use memory backed streams, make sure nothing goes awry there
2. Manually verify that you can run ./wadm --stream-persistence file, close the wadm instance, then ./wadm --stream-persistence memory without issue.