fix(server): Added validation for duplicated link config names #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
If an application manifest is applied in which several link configurations have the same name, this leads to a dead loop.
Related Issues
closes #478
Release Information
This PR fixes a problem without making any breaking changes. It can therefore be safely included in the next version.
Consumer Impact
This PR introduces an additional validation logic that prevents users to apply invalid manifests. If the manifest is valid, nothing changes for the users.
Additionally, it is planned to modify the
BackoffWrapper
and introduce an exponentially increasing delay for a retry in case of an error, which introduces longer feedback loops for (debugging) users.Testing
Unit Test(s)
Acceptance or Integration
An additional test case has been added for the new validation logic.