Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): support editing existing automations #9246

Open
wants to merge 1 commit into
base: tonyyli/automations-api
Choose a base branch
from

Conversation

tonyyli-wandb
Copy link
Contributor

@tonyyli-wandb tonyyli-wandb commented Jan 11, 2025

Description

Adds wandb.Api support for updating existing automations.

  • I updated CHANGELOG.unreleased.md, or it's not applicable

Testing

How was this PR tested?

@tonyyli-wandb tonyyli-wandb marked this pull request as ready for review January 11, 2025 05:11
@tonyyli-wandb tonyyli-wandb requested review from a team as code owners January 11, 2025 05:11
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 52.77778% with 17 lines in your changes missing coverage. Please review.

Project coverage is 72.69%. Comparing base (8f8f7dd) to head (c4e1ac9).

Files with missing lines Patch % Lines
wandb/apis/public/api.py 44.44% 15 Missing ⚠️
wandb/sdk/automations/automations.py 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           tonyyli/automations-api    #9246      +/-   ##
===========================================================
- Coverage                    72.72%   72.69%   -0.03%     
===========================================================
  Files                          575      575              
  Lines                        59359    59394      +35     
===========================================================
+ Hits                         43167    43176       +9     
- Misses                       15480    15501      +21     
- Partials                       712      717       +5     
Flag Coverage Δ
func 37.69% <11.11%> (+<0.01%) ⬆️
system 58.10% <52.77%> (+<0.01%) ⬆️
unit 52.18% <11.11%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
wandb/sdk/automations/_utils.py 74.39% <100.00%> (+19.12%) ⬆️
wandb/sdk/automations/automations.py 92.06% <33.33%> (-2.94%) ⬇️
wandb/apis/public/api.py 77.32% <44.44%> (-0.03%) ⬇️

... and 9 files with indirect coverage changes

@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from c24aea8 to b7fffcc Compare January 12, 2025 00:53
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from 5a8003a to 998139b Compare January 12, 2025 00:53
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from b7fffcc to 980ac89 Compare January 12, 2025 22:49
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from 998139b to 461af1b Compare January 12, 2025 22:49
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from 980ac89 to 2b6c6cb Compare January 13, 2025 17:47
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch 2 times, most recently from f46c91f to 46b6e96 Compare January 13, 2025 18:34
@tonyyli-wandb tonyyli-wandb marked this pull request as draft January 13, 2025 18:37
@tonyyli-wandb tonyyli-wandb removed request for a team January 13, 2025 18:37
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from 2b6c6cb to 09fbee1 Compare January 13, 2025 19:33
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from 46b6e96 to a59b992 Compare January 13, 2025 19:34
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from 09fbee1 to bfdefa2 Compare January 14, 2025 00:54
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch 2 times, most recently from 758289d to 57f0405 Compare January 14, 2025 00:58
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from bfdefa2 to 9ca1c64 Compare January 14, 2025 01:11
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from 6ddc68f to f643919 Compare January 21, 2025 22:14
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from 8d7008f to 57d1598 Compare January 21, 2025 22:14
Copy link
Contributor

@ibindlish ibindlish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from f643919 to 504ef18 Compare January 22, 2025 14:53
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from 57d1598 to f3a2b1d Compare January 22, 2025 14:54
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from 504ef18 to d147c86 Compare January 22, 2025 15:26
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from f3a2b1d to 76bdae5 Compare January 22, 2025 15:27
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from d147c86 to f10a6b7 Compare January 22, 2025 15:34
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from 76bdae5 to 388b221 Compare January 22, 2025 15:35
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from f10a6b7 to 9a92df0 Compare January 22, 2025 15:45
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from 388b221 to 90c6218 Compare January 22, 2025 15:45
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from 9a92df0 to 845245d Compare January 22, 2025 16:07
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from 90c6218 to 8dfa038 Compare January 22, 2025 16:07
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from 845245d to 48ef37d Compare January 22, 2025 19:55
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from 8dfa038 to 7291dbf Compare January 22, 2025 19:55
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from 48ef37d to e29284a Compare January 22, 2025 20:08
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from 7291dbf to 29ee21a Compare January 22, 2025 20:08
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from e29284a to f2d482d Compare January 22, 2025 20:20
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from 29ee21a to 9616908 Compare January 22, 2025 20:20
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from f2d482d to 6cb3476 Compare January 22, 2025 20:27
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from 9616908 to 1922928 Compare January 22, 2025 20:27
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from 6cb3476 to 77a6237 Compare January 22, 2025 20:43
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from 1922928 to ae9f23b Compare January 22, 2025 20:43
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from 77a6237 to 7ff0132 Compare January 22, 2025 21:31
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from ae9f23b to f8062cc Compare January 22, 2025 21:31
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from 7ff0132 to 8f8f7dd Compare January 22, 2025 21:46
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from f8062cc to c4e1ac9 Compare January 22, 2025 21:47
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api branch from 8f8f7dd to 3f71bfb Compare January 27, 2025 22:21
@tonyyli-wandb tonyyli-wandb force-pushed the tonyyli/automations-api-update branch from c4e1ac9 to 22c6442 Compare January 27, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants