chore(dev): bump view spec version to 1 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jo-fang
changed the title
jo-fang
force-pushed
the
joyce/bump-spec-version
branch
from
4094304 to
92b3e3a
Compare
jo-fang
changed the title
wandb_workspaces/utils/validators.py
Outdated
Comment on lines
19
to
22
|
|
||
| if actual_version <= 1: | ||
| return spec | ||
|
|
There was a problem hiding this comment.
I think this is breaking tests. Why do you need this?
There was a problem hiding this comment.
okay i overthought my migration logic - changed to just update client spec version
jo-fang
force-pushed
the
joyce/bump-spec-version
branch
2 times, most recently
from
60be105 to
e7c01d8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 70.88% 70.89% +0.01%
==========================================
Files 16 16
Lines 2349 2350 +1
==========================================
+ Hits 1665 1666 +1
Misses 684 684
|
jo-fang
force-pushed
the
joyce/bump-spec-version
branch
from
96d653d to
fb11d63
Compare
jo-fang
force-pushed
the
joyce/bump-spec-version
branch
from
d7c0aad to
a6fc59e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wandb.atlassian.net/browse/WB-19379