Fix: Prevent diffs appearing when nothing has changed in PSC configs (#…

…209)

* fix: Try setting this full url as that seems to cause a diff in TFC

* fix: change id to self link

* fix: ignore changes to region as this will never change

modules/private_link/main.tf

@@ -6,7 +6,7 @@ resource "google_compute_subnetwork" "proxy" {
   ip_cidr_range = var.proxynetwork_cidr
   purpose       = "REGIONAL_MANAGED_PROXY"
   role          = "ACTIVE"
-  network       = var.network.id
+  network       = var.network.self_link
   timeouts {
     delete = "2m"
   }
@@ -17,7 +17,11 @@ resource "google_compute_region_network_endpoint_group" "external_lb" {
   region = data.google_client_config.current.region
 
   network_endpoint_type = "INTERNET_FQDN_PORT"
-  network               = var.network.id
+  network               = var.network.self_link
+
+  lifecycle {
+    ignore_changes = [region]
+  }
 }
 
 resource "google_compute_region_network_endpoint" "external_lb" {
@@ -52,7 +56,7 @@ resource "google_compute_forwarding_rule" "internal_nlb" {
 
   target = google_compute_region_target_tcp_proxy.internal_nlb.id
 
-  network    = var.network.id
+  network    = var.network.self_link
   subnetwork = var.subnetwork.self_link
 
   depends_on = [google_compute_subnetwork.proxy]
@@ -79,7 +83,7 @@ resource "google_compute_service_attachment" "default" {
 
 resource "google_compute_subnetwork" "default" {
   name          = "${var.namespace}-psc-ilb-subnet"
-  network       = var.network.id
+  network       = var.network.self_link
   purpose       = "PRIVATE_SERVICE_CONNECT"
   ip_cidr_range = var.psc_subnetwork
 }
@@ -90,7 +94,7 @@ resource "google_compute_firewall" "default" {
   name          = "${var.namespace}-internal-fw"
   provider      = google-beta
   direction     = "INGRESS"
-  network       = var.network.id
+  network       = var.network.self_link
   source_ranges = ["130.211.0.0/22", "35.191.0.0/16", "35.235.240.0/20", var.proxynetwork_cidr]
   allow {
     protocol = "tcp"

modules/private_link/variables.tf

@@ -5,7 +5,7 @@ variable "namespace" {
 
 variable "network" {
   description = "Google Compute Engine network to which the cluster is connected."
-  type        = object({ id = string })
+  type        = object({ self_link = string })
 }
 
 variable "subnetwork" {