Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new pages to tables chapter. #516

Merged
merged 8 commits into from
Oct 3, 2024

Conversation

katjacksonWB
Copy link
Contributor

@katjacksonWB katjacksonWB commented Dec 11, 2023

Description

Adds two new pages to the tables chapter that describe creating and managing tables.

Ticket

Checklist

Check if your PR fulfills the following requirements. Put an X in the boxes that apply.

  • Files I edited were previewed on my local development server with yarn start. My changes did not break the local preview.
  • Build (yarn docusaurus build) was run locally and successfully without errors or warnings.
  • I merged the latest changes from main into my feature branch before submitting this PR.

@katjacksonWB katjacksonWB requested a review from a team as a code owner December 11, 2023 21:01
Copy link
Contributor

@ngrayluna ngrayluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main callout is changing the tone from passive to active. I didn't comment on the tables-navigate.md page because I realized that it wasn't constructive to leave the same note for each section.


Unlike traditional spreadsheets, Tables support numerous types of data:
scalar values, strings, numpy arrays, and most subclasses of `wandb.data_types.Media`.
This means you can embed `Images`, `Video`, `Audio`, and other sorts of rich, annotated media
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's break this up into two short sentences.

This means you can embed `Images`, `Video`, `Audio`, and other sorts of rich, annotated media
directly in Tables, alongside other traditional scalar values.

Tables can be constructed with initial data using the `data` or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Active voice example: Construct Tables with....

Let's elaborate on what data and dataframe parameters mean. In the code example I don't see a dataframe parameter.

```
## Add Data

You can add data to Tables incrementally by using the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Active voice: Add data to Tables incrementally with....."

wandb.log({"classifier_out": tbl})
```

Tables added directly to runs as above will produce a corresponding Table Visualizer in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When referring to code snippets that happened before or after a text, use "proceeding" or "preceding".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to avoid using "which". ESL customers have a hard time with that word. Use a lot of "that".

Tables added directly to runs will produce a Table Visualizer in the W&B Workspace. You can use the visualizer to explore and analyze data.

docs/guides/tables/tables-create.md Outdated Show resolved Hide resolved
docs/guides/tables/tables-create.md Outdated Show resolved Hide resolved
docs/guides/tables/tables-navigate.md Show resolved Hide resolved
docs/guides/tables/tables-create.md Outdated Show resolved Hide resolved
docs/guides/tables/tables-create.md Outdated Show resolved Hide resolved
@@ -34,7 +34,7 @@ df = table.get_dataframe()
```

## Export Data
Now you can export using any method dataframe supports:
Now, export using any method dataframe supports:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: "Now" -> "Next,"

## The W&B platform
When first opening your workspace, you can see a simple visualization of your tables. Each table you create appears in a `panel` where you can further customize your data.

There is also a statement on the top of your panel. If you're following one of the example guides, this statement should bevalv `runs.summary["Table Name"]`. You can also edit this statement.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spell check

@ngrayluna ngrayluna self-requested a review January 13, 2024 00:17
Copy link
Contributor

@ngrayluna ngrayluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some checks left

Copy link
Contributor

@ngrayluna ngrayluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Looks like there are some style changes to be done to the tables-navigate doc

@johndmulhausen johndmulhausen changed the base branch from main to katjackson-tables October 3, 2024 19:44
@johndmulhausen johndmulhausen merged commit c800259 into katjackson-tables Oct 3, 2024
4 of 5 checks passed
@johndmulhausen johndmulhausen deleted the katjackson-createtables branch October 3, 2024 19:45
displayed_sidebar: default
---

# Manage Tables
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Google.Headings] 'Manage Tables' should use sentence-style capitalization.


Once you've [created a table](./tables-create.md), you can use the W&B platform to analyze, customize, and manage your data.

## The W&B Platform
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Google.Headings] 'The W&B Platform' should use sentence-style capitalization.

Once you've [created a table](./tables-create.md), you can use the W&B platform to analyze, customize, and manage your data.

## The W&B Platform
When you first open your workspace, you will be presented with a simple visualization of your tables. Each table you create appears in a `panel` where you can further customize your data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Google.Will] Avoid using 'will'.

Once you've [created a table](./tables-create.md), you can use the W&B platform to analyze, customize, and manage your data.

## The W&B Platform
When you first open your workspace, you will be presented with a simple visualization of your tables. Each table you create appears in a `panel` where you can further customize your data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [vale] reported by reviewdog 🐶
[Google.Passive] In general, use active voice instead of passive voice ('be presented').

## The W&B Platform
When you first open your workspace, you will be presented with a simple visualization of your tables. Each table you create appears in a `panel` where you can further customize your data.

You'll also notice a statement at the top of your panel. If you're following one of our example guides, it will look something like `runs.summary["Table Name"]`. You can edit this statement, which will be discussed later.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Google.We] Try to avoid using first-person plural like 'our'.

- row
- range

For more information on visualizing tables, see our [full guide](./visualize-tables.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Google.We] Try to avoid using first-person plural like 'our'.


For more information on visualizing tables, see our [full guide](./visualize-tables.md).

## Export Data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Google.Headings] 'Export Data' should use sentence-style capitalization.

## Export Data
You can easily export your table data to a .csv file by clicking the `Export to CSV` button, usually located at the bottom of a table's panel. Clicking this button automatically downloads a .csv file of your current table, with any formats or editing you have made.

For more methods of exporting data, see our [full guide](./tables-download.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Google.We] Try to avoid using first-person plural like 'our'.


For more methods of exporting data, see our [full guide](./tables-download.md).

## Next Steps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Google.Headings] 'Next Steps' should use sentence-style capitalization.

For more methods of exporting data, see our [full guide](./tables-download.md).

## Next Steps
For a more in-depth walkthrough of how to use tables, see our [walkthrough](tables-walkthrough.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Google.We] Try to avoid using first-person plural like 'our'.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Summary

Status Count
🔍 Total 15
✅ Successful 1
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 14
❓ Unknown 0
🚫 Errors 0
Full Github Actions output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants