-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new pages to tables chapter. #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main callout is changing the tone from passive to active. I didn't comment on the tables-navigate.md page because I realized that it wasn't constructive to leave the same note for each section.
docs/guides/tables/tables-create.md
Outdated
|
||
Unlike traditional spreadsheets, Tables support numerous types of data: | ||
scalar values, strings, numpy arrays, and most subclasses of `wandb.data_types.Media`. | ||
This means you can embed `Images`, `Video`, `Audio`, and other sorts of rich, annotated media |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's break this up into two short sentences.
docs/guides/tables/tables-create.md
Outdated
This means you can embed `Images`, `Video`, `Audio`, and other sorts of rich, annotated media | ||
directly in Tables, alongside other traditional scalar values. | ||
|
||
Tables can be constructed with initial data using the `data` or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Active voice example: Construct Tables with....
Let's elaborate on what data
and dataframe
parameters mean. In the code example I don't see a dataframe parameter.
docs/guides/tables/tables-create.md
Outdated
``` | ||
## Add Data | ||
|
||
You can add data to Tables incrementally by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Active voice: Add data to Tables incrementally with....."
docs/guides/tables/tables-create.md
Outdated
wandb.log({"classifier_out": tbl}) | ||
``` | ||
|
||
Tables added directly to runs as above will produce a corresponding Table Visualizer in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When referring to code snippets that happened before or after a text, use "proceeding" or "preceding".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to avoid using "which". ESL customers have a hard time with that word. Use a lot of "that".
Tables added directly to runs will produce a Table Visualizer in the W&B Workspace. You can use the visualizer to explore and analyze data.
@@ -34,7 +34,7 @@ df = table.get_dataframe() | |||
``` | |||
|
|||
## Export Data | |||
Now you can export using any method dataframe supports: | |||
Now, export using any method dataframe supports: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: "Now" -> "Next,"
## The W&B platform | ||
When first opening your workspace, you can see a simple visualization of your tables. Each table you create appears in a `panel` where you can further customize your data. | ||
|
||
There is also a statement on the top of your panel. If you're following one of the example guides, this statement should bevalv `runs.summary["Table Name"]`. You can also edit this statement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spell check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some checks left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Looks like there are some style changes to be done to the tables-navigate doc
displayed_sidebar: default | ||
--- | ||
|
||
# Manage Tables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.Headings] 'Manage Tables' should use sentence-style capitalization.
|
||
Once you've [created a table](./tables-create.md), you can use the W&B platform to analyze, customize, and manage your data. | ||
|
||
## The W&B Platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.Headings] 'The W&B Platform' should use sentence-style capitalization.
Once you've [created a table](./tables-create.md), you can use the W&B platform to analyze, customize, and manage your data. | ||
|
||
## The W&B Platform | ||
When you first open your workspace, you will be presented with a simple visualization of your tables. Each table you create appears in a `panel` where you can further customize your data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.Will] Avoid using 'will'.
Once you've [created a table](./tables-create.md), you can use the W&B platform to analyze, customize, and manage your data. | ||
|
||
## The W&B Platform | ||
When you first open your workspace, you will be presented with a simple visualization of your tables. Each table you create appears in a `panel` where you can further customize your data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [vale] reported by reviewdog 🐶
[Google.Passive] In general, use active voice instead of passive voice ('be presented').
## The W&B Platform | ||
When you first open your workspace, you will be presented with a simple visualization of your tables. Each table you create appears in a `panel` where you can further customize your data. | ||
|
||
You'll also notice a statement at the top of your panel. If you're following one of our example guides, it will look something like `runs.summary["Table Name"]`. You can edit this statement, which will be discussed later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.We] Try to avoid using first-person plural like 'our'.
- row | ||
- range | ||
|
||
For more information on visualizing tables, see our [full guide](./visualize-tables.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.We] Try to avoid using first-person plural like 'our'.
|
||
For more information on visualizing tables, see our [full guide](./visualize-tables.md). | ||
|
||
## Export Data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.Headings] 'Export Data' should use sentence-style capitalization.
## Export Data | ||
You can easily export your table data to a .csv file by clicking the `Export to CSV` button, usually located at the bottom of a table's panel. Clicking this button automatically downloads a .csv file of your current table, with any formats or editing you have made. | ||
|
||
For more methods of exporting data, see our [full guide](./tables-download.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.We] Try to avoid using first-person plural like 'our'.
|
||
For more methods of exporting data, see our [full guide](./tables-download.md). | ||
|
||
## Next Steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.Headings] 'Next Steps' should use sentence-style capitalization.
For more methods of exporting data, see our [full guide](./tables-download.md). | ||
|
||
## Next Steps | ||
For a more in-depth walkthrough of how to use tables, see our [walkthrough](tables-walkthrough.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.We] Try to avoid using first-person plural like 'our'.
Summary
|
Description
Adds two new pages to the tables chapter that describe creating and managing tables.
Ticket
Checklist
Check if your PR fulfills the following requirements. Put an
X
in the boxes that apply.yarn start
. My changes did not break the local preview.yarn docusaurus build
) was run locally and successfully without errors or warnings.main
into my feature branch before submitting this PR.